Fix #9257

changelog/unreleased/bugfix-filter-shares-without-displayname

@@ -0,0 +1,7 @@
+Bugfix: Filter out shares without display name
+
+In rare (legacy) cases, shares can exist without a displayName key, which caused trouble in the sharing sidebar section.
+This has been addressed by filtering out shares without a displayName.
+
+https://github.com/owncloud/web/issues/9257
+https://github.com/owncloud/web/pull/9504

packages/web-app-files/src/components/SideBar/Shares/FileShares.vue

@@ -198,17 +198,20 @@ export default defineComponent({
     },
 
     collaborators() {
-      return [...this.outgoingCollaborators].sort(this.collaboratorsComparator).map((c) => {
-        const collaborator: typeof c & { key?: string; resharers?: User[] } = { ...c }
-        collaborator.key = 'collaborator-' + collaborator.id
-        if (
-          collaborator.owner.name !== collaborator.fileOwner.name &&
-          collaborator.owner.name !== this.user.id
-        ) {
-          collaborator.resharers = [collaborator.owner]
-        }
-        return collaborator
-      })
+      return [...this.outgoingCollaborators]
+        .filter((c) => c.collaborator.displayName)
+        .sort(this.collaboratorsComparator)
+        .map((c) => {
+          const collaborator: typeof c & { key?: string; resharers?: User[] } = { ...c }
+          collaborator.key = 'collaborator-' + collaborator.id
+          if (
+            collaborator.owner.name !== collaborator.fileOwner.name &&
+            collaborator.owner.name !== this.user.id
+          ) {
+            collaborator.resharers = [collaborator.owner]
+          }
+          return collaborator
+        })
     },
 
     displayCollaborators() {

packages/web-app-files/tests/unit/components/SideBar/Shares/FileShares.spec.ts

@@ -77,6 +77,19 @@ describe('FileShares', () => {
       expect(wrapper.findAll('#files-collaborators-list li').length).toBe(collaborators.length)
       expect(wrapper.html()).toMatchSnapshot()
     })
+    it('filters out collaborator without displayName', () => {
+      const collaboratorsWithDisallowed = [
+        ...collaborators,
+        {
+          ...getCollaborator(),
+          collaborator: { name: 'foo', additionalInfo: 'some' }
+        }
+      ]
+      const { wrapper } = getWrapper({ collaborators: collaboratorsWithDisallowed })
+      expect(wrapper.findAll('#files-collaborators-list li').length).toBe(
+        collaboratorsWithDisallowed.length - 1
+      )
+    })
     it('reacts on delete events', async () => {
       const spyOnCollaboratorDeleteTrigger = jest
         .spyOn((FileShares as any).methods, '$_ocCollaborators_deleteShare_trigger')