Add acceptance test for creating new file

owncloud · Oct 14, 2019 · a98ccb7 · a98ccb7
1 parent 33cb0c0
commit a98ccb7
Show file tree

Hide file tree

Showing 3 changed files with 55 additions and 1 deletion.
diff --git a/tests/acceptance/features/webUIFiles/hiddenFile.feature b/tests/acceptance/features/webUIFiles/hiddenFile.feature
@@ -16,3 +16,9 @@ Feature: Hide file/folders
     Then folder ".xyz" should not be listed on the webUI
     When the user enables the setting to view hidden folders on the webUI
     Then folder ".xyz" should be listed on the webUI
+
+  Scenario: create a hidden file
+    When the user creates a file with the name ".hiddenFile.txt" using the webUI
+    Then file ".hiddenFile.txt" should not be listed on the webUI
+    When the user enables the setting to view hidden files on the webUI
+    Then file ".hiddenFile.txt" should be listed on the webUI
diff --git a/tests/acceptance/pageObjects/filesPage.js b/tests/acceptance/pageObjects/filesPage.js
@@ -52,6 +52,32 @@ module.exports = {
       }
       return this
     },
+    /**
+     * Create a file with the given name
+     *
+     * @param {string} name to set or null to use default value from dialog
+     * @param {boolean} expectToSucceed
+     */
+    createFile: function (name, expectToSucceed = true) {
+      this
+        .waitForElementVisible('@newFileMenuButton')
+        .click('@newFileMenuButton')
+        .waitForElementVisible('@newFileButton')
+        .click('@newFileButton')
+        .waitForElementVisible('@newFileInput')
+      if (name !== null) {
+        this.clearValueWithEvent('@newFileInput')
+        this.setValue('@newFileInput', name)
+      }
+      this
+        .click('@newFileOkButton')
+        .waitForElementNotPresent('@createFileLoadingIndicator')
+      if (expectToSucceed) {
+        this.waitForElementNotVisible('@newFileDialog')
+          .waitForAnimationToFinish()
+      }
+      return this
+    },
     /**
      *
      * @param {string} localFileName
@@ -175,15 +201,29 @@ module.exports = {
     newFolderButton: {
       selector: '#new-folder-btn'
     },
+    newFileButton: {
+      selector: '#new-file-btn'
+    },
     newFolderDialog: {
       selector: '#new-folder-dialog'
     },
+    newFileDialog: {
+      selector: '#new-file-dialog'
+    },
     newFolderInput: {
       selector: '#new-folder-input'
     },
+    newFileInput: {
+      selector: "//input[@placeholder='Create new file…']",
+      locateStrategy: 'xpath'
+    },
     newFolderOkButton: {
       selector: '#new-folder-ok'
     },
+    newFileOkButton: {
+      selector: "//div[@id='new-file-dialog']//span[contains(text(),'Ok')]",
+      locateStrategy: 'xpath'
+    },
     permalinkCopyButton: {
       selector: '#files-permalink-copy'
     },
@@ -215,6 +255,10 @@ module.exports = {
       selector: '//div[@id="new-folder-dialog"]//div[@class="oc-loader"]',
       locateStrategy: 'xpath'
     },
+    createFileLoadingIndicator: {
+      selector: '//div[@id="new-file-dialog"]//div[@class="oc-loader"]',
+      locateStrategy: 'xpath'
+    },
     fileUploadButton: {
       selector: '#files-file-upload-button'
     },

diff --git a/tests/acceptance/stepDefinitions/filesContext.js b/tests/acceptance/stepDefinitions/filesContext.js
@@ -98,6 +98,10 @@ When('the user creates a folder with the name {string} using the webUI', functio
   return client.page.filesPage().createFolder(folderName)
 })
 
+When('the user creates a file with the name {string} using the webUI', function (fileName) {
+  return client.page.filesPage().createFile(fileName)
+})
+
 When('the user creates a folder with default name using the webUI', function () {
   return client.page.filesPage().createFolder(null, false)
 })
@@ -117,7 +121,7 @@ Given('the user has opened the share dialog for folder {string}', function (file
   return client.page.FilesPageElement.filesList().openSharingDialog(fileName)
 })
 
-When('the user enables the setting to view hidden folders on the webUI', function () {
+When('the user enables the setting to view hidden files/folders on the webUI', function () {
   return client.page.filesPage().showHiddenFiles()
 })