Merge pull request #8947 from owncloud/fix-infinite-login-redirect

fix: infinite login redirect loop
owncloud · Apr 27, 2023 · abf9977 · abf9977
2 parents 35a4b1b + b80b586
commit abf9977
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/changelog/unreleased/bugfix-infinite-login-redirect b/changelog/unreleased/bugfix-infinite-login-redirect
@@ -0,0 +1,8 @@
+Bugfix: Infinite login redirect
+
+We've fixed a bug where a user would fall into an infinite redirect between login and accessDenied page if a) the user had valid IdP credentials but was not permitted in ocis, b) the user has authenticated successfully but then got deleted in the meantime.
+
+https://github.com/owncloud/web/issues/8928
+https://github.com/owncloud/web/issues/7354
+https://github.com/owncloud/web/issues/4677
+https://github.com/owncloud/web/pull/8947
diff --git a/packages/web-runtime/src/services/auth/authService.ts b/packages/web-runtime/src/services/auth/authService.ts
@@ -219,7 +219,12 @@ export class AuthService {
  }
  if (isUserContext(this.router, route)) {
  await this.userManager.removeUser('authError')
+ return
  }
+ // authGuard is taking care of redirecting the user to the
+ // accessDenied page if hasAuthErrorOccurred is set to true
+ // we can't push the route ourselves, see authGuard for details.
+ this.hasAuthErrorOccurred = true
  }
 
  public async resolvePublicLink(token: string, passwordRequired: boolean, password: string) {