Merge pull request #4820 from owncloud/node-env

set NODE_ENV based on rollup build type
owncloud · Mar 17, 2021 · bf22ec3 · bf22ec3
2 parents 5a56117 + 9dee55b
commit bf22ec3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/changelog/unreleased/fix-node-env b/changelog/unreleased/fix-node-env
@@ -0,0 +1,6 @@
+Bugfix: NODE_ENV based on rollup mode
+
+The NODE_ENV was set to production by default, now we use development if rollup is started in watch mode so that the vue devtools can be used.
+
+https://github.com/owncloud/web/issues/4819
+https://github.com/owncloud/web/pull/4820
diff --git a/rollup.config.js b/rollup.config.js
@@ -47,7 +47,7 @@ const plugins = [
  exclude: 'node_modules/**'
  }),
  modify({
- 'process.env.NODE_ENV': JSON.stringify('production'),
+ 'process.env.NODE_ENV': JSON.stringify(production ? 'production' : 'development'),
  // todo: remove after pending PR is merged
  // fix for 'assignment to undeclared variable dav' in davclient.js/lib/client.js 6:0
  "if (typeof dav === 'undefined') { dav = {}; }": 'var dav = dav || {}',