-
Notifications
You must be signed in to change notification settings - Fork 157
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: remove opinionated components from ODS
Removes the following opinionated components from the ODS and moves them to `web-pkg` instead: - `OcResource` (now `ResourceListItem`) - `OcTile` (now `ResourceTile`) - `OcResourceIcon` (now `ResourceIcon`) - `OcGhostElement` (now `DragGhostElement`) Those components hold logic about resources, which is something that is not supposed to live in the ODS. The ODS should only contain design- and layout-specific components.
- Loading branch information
1 parent
7add9fb
commit c09a296
Showing
50 changed files
with
491 additions
and
608 deletions.
There are no files selected for viewing
12 changes: 12 additions & 0 deletions
12
packages/design-system/changelog/unreleased/change-remove-opinionated-components
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
Change: Remove opinionated components | ||
|
||
We've removed the following opinionated components from the ODS and moved them to `web-pkg` instead: | ||
|
||
- `OcResource` (now `ResourceListItem`) | ||
- `OcTile` (now `ResourceTile`) | ||
- `OcResourceIcon` (now `ResourceIcon`) | ||
- `OcGhostElement` (now `DragGhostElement`) | ||
|
||
Those components hold logic about resources, which is something that is not supposed to live in the ODS. The ODS should only contain design- and layout-specific components. | ||
|
||
https://github.com/owncloud/web/pull/10293 |
246 changes: 0 additions & 246 deletions
246
...ges/design-system/src/components/OcResourceIcon/__snapshots__/OcResourceIcon.spec.ts.snap
This file was deleted.
Oops, something went wrong.
4 changes: 0 additions & 4 deletions
4
packages/design-system/src/components/OcResourceIcon/types.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.