Skip to content

Commit

Permalink
Fix filename column width in responsive mode
Browse files Browse the repository at this point in the history
Removed uk-width-small and now using the icon width for column
alignment. This gives more space in responsive mode for the file name
column.
Removed the "More" column header label which felt redundant.
Adjusted file actions button id to not mention size any more, now that
we only have a single size.
  • Loading branch information
Vincent Petry committed Feb 11, 2020
1 parent 0e875b2 commit dac040b
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 8 deletions.
16 changes: 10 additions & 6 deletions apps/files/src/components/FileList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,8 @@
</div>
<slot name="headerColumns"/>
<div
class="uk-text-meta uk-text-right uk-width-small uk-margin-small-right"
v-translate
class="uk-margin-small-right oc-icon-width"
>
More
</div>
</oc-grid>
<div id="files-list-container" class="uk-flex-1" v-if="!loading">
Expand All @@ -46,7 +44,7 @@
/>
</div>
<slot name="rowColumns" :item="item" :index="item.id" />
<div class="uk-width-small uk-text-right uk-margin-small-right">
<div class="uk-text-right uk-margin-small-right">
<oc-button
:id="actionsDropdownButtonId(item.id, active)"
class="files-list-row-show-actions"
Expand Down Expand Up @@ -299,11 +297,17 @@ export default {
actionsDropdownButtonId (id, active) {
if (active) {
return `files-file-list-action-button-small-resolution-${id}-active`
return `files-file-list-action-button-${id}-active`
}
return `files-file-list-action-button-small-resolution-${id}`
return `files-file-list-action-button-${id}`
}
}
}
</script>
<style scoped>
/* FIXME: move to ODS, it is useful to have a column as wide as just an icon */
.oc-icon-width {
width: 24px;
}
</style>
4 changes: 2 additions & 2 deletions apps/files/src/components/FilesLists/RowActionsDropdown.vue
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<template>
<oc-drop
v-if="displayed"
:boundary="`#files-file-list-action-button-small-resolution-${item.id}-active`"
:boundary="`#files-file-list-action-button-${item.id}-active`"
:options="{ offset: 0 }"
:toggle="`#files-file-list-action-button-small-resolution-${item.id}-active`"
:toggle="`#files-file-list-action-button-${item.id}-active`"
position="bottom-right"
id="files-list-row-actions-dropdown"
class="uk-open uk-drop-stack"
Expand Down
1 change: 1 addition & 0 deletions changelog/unreleased/2974
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ This change hides them behind a three dots button on the line, the same that was
The three dots button also now has no more border and looks nicer.

https://github.com/owncloud/phoenix/pull/2974
https://github.com/owncloud/phoenix/issues/2998

0 comments on commit dac040b

Please sign in to comment.