Fix acceptance && E2E tests now that public links open in editors by …

…default

tests/acceptance/expected-failures-with-oc10-server-oauth2-login.md

@@ -18,7 +18,7 @@ Other free text and markdown formatting can be used elsewhere in the document if
 -   [webUISharingPublicManagement/shareByPublicLink.feature:24](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicManagement/shareByPublicLink.feature#L24)
 
 ### [Uploading folders does not work in files-drop](https://github.com/owncloud/web/issues/2443)
--   [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:268](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L268)
+-   [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:273](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L273)
 
 ### [Writing to locked files/folders give only a generic error message](https://github.com/owncloud/web/issues/5741)
 -   [webUIWebdavLockProtection/upload.feature:32](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/upload.feature#L32)

tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md

@@ -31,7 +31,7 @@ Other free text and markdown formatting can be used elsewhere in the document if
 -   [webUIResharing1/reshareUsers.feature:177](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIResharing1/reshareUsers.feature#L177)
 
 ### [when sharer renames the shared resource, sharee get the updated name](https://github.com/owncloud/ocis/issues/2256)
--   [webUIRenameFiles/renameFiles.feature:226](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIRenameFiles/renameFiles.feature#L226)
+-   [webUIRenameFiles/renameFiles.feature:227](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIRenameFiles/renameFiles.feature#L227)
 
 ### [Cannot create users with special characters](https://github.com/owncloud/ocis/issues/1417)
 -   [webUISharingAutocompletion/shareAutocompletionSpecialChars.feature:37](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAutocompletion/shareAutocompletionSpecialChars.feature#L37)
@@ -53,7 +53,7 @@ Other free text and markdown formatting can be used elsewhere in the document if
 - [webUISharingExpirationDate/shareWithExpirationDate.feature:21](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingExpirationDate/shareWithExpirationDate.feature#L21)
 
 ### [Listing shares via ocs API does not show path for parent folders](https://github.com/owncloud/ocis/issues/1231)
--   [webUISharingPublicManagement/shareByPublicLink.feature:110](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicManagement/shareByPublicLink.feature#L110)
+-   [webUISharingPublicManagement/shareByPublicLink.feature:111](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicManagement/shareByPublicLink.feature#L111)
 
 ### [Propfind response to trashbin endpoint is different in ocis](https://github.com/owncloud/product/issues/186)
 -   [webUIFilesSearch/search.feature:131](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesSearch/search.feature#L131)
@@ -84,13 +84,13 @@ Other free text and markdown formatting can be used elsewhere in the document if
 -   [webUISharingPublicManagement/shareByPublicLink.feature:24](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicManagement/shareByPublicLink.feature#L24)
 
 ### [Uploading folders does not work in files-drop](https://github.com/owncloud/web/issues/2443)
--   [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:268](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L268)
+-   [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:273](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L273)
 
 ### [Resources cannot be locked under ocis](https://github.com/owncloud/ocis/issues/1284)
--   [webUIWebdavLockProtection/delete.feature:33](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/delete.feature#L33)
 -   [webUIWebdavLockProtection/delete.feature:34](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/delete.feature#L34)
--   [webUIWebdavLockProtection/move.feature:36](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/move.feature#L36)
+-   [webUIWebdavLockProtection/delete.feature:35](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/delete.feature#L35)
 -   [webUIWebdavLockProtection/move.feature:37](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/move.feature#L37)
+-   [webUIWebdavLockProtection/move.feature:38](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/move.feature#L38)
 -   [webUIWebdavLockProtection/upload.feature:32](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIWebdavLockProtection/upload.feature#L32)
 
 ### [Resources cannot be locked under ocis](https://github.com/owncloud/ocis/issues/1284)
@@ -113,7 +113,7 @@ Other free text and markdown formatting can be used elsewhere in the document if
 ### [Favorites deactivated in ocis temporarily](https://github.com/owncloud/ocis/issues/1228)
 -   [webUIFilesDetails/fileDetails.feature:47](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L47)
 -   [webUIFilesDetails/fileDetails.feature:67](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L67)
--   [webUIRenameFiles/renameFiles.feature:249](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIRenameFiles/renameFiles.feature#L249)
+-   [webUIRenameFiles/renameFiles.feature:250](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIRenameFiles/renameFiles.feature#L250)
 
 ### [PROPFIND to sub-folder of a shared resources with same name gives 404](https://github.com/owncloud/ocis/issues/3859)
 -   [webUISharingAcceptShares/acceptShares.feature:240](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L240)

tests/acceptance/features/webUIPrivateLinks/accessingPrivateLinks.feature

@@ -11,6 +11,7 @@ Feature: Access private link
     Given user "Alice" has logged in using the webUI
     When the user copies the private link of the file "lorem.txt" using the webUI
     And the user navigates to the copied private link using the webUI
+    And the user closes the text editor using the webUI
     Then file "lorem.txt" should be listed on the webUI
 
   @smokeTest
@@ -27,6 +28,7 @@ Feature: Access private link
     And user "Brian" has logged in using the webUI
     When the user navigates to the private link created by user "Alice" for file "lorem.txt"
     And the private link resolved successfully
+    And the user closes the text editor using the webUI
     Then file "lorem.txt" should be listed on the webUI
 
   @issue-3243

tests/acceptance/features/webUIRenameFiles/renameFiles.feature

@@ -188,6 +188,7 @@ Feature: rename files
     And user "Alice" has uploaded file "lorem.txt" to "simple-folder/lorem.txt" in the server
     And user "Alice" has shared folder "simple-folder" with link with "read, update, create, delete" permissions in the server
     When the public uses the webUI to access the last public link created by user "Alice" in a new session
+    And the user closes the text editor using the webUI
     And the user renames single share "lorem.txt" to "a-renamed-file.txt" using the webUI
     Then file "a-renamed-file.txt" should be listed on the webUI as single share
     But file "lorem.txt" should not be listed on the webUI

tests/acceptance/features/webUISharingPublicBasic/publicLinkCreate.feature

@@ -22,6 +22,7 @@ Feature: Create public link shares
       | name        | Link           |
     And a link named "Link" should be listed with role "Anyone with the link can view" in the public link list of resource "simple-folder" on the webUI
     When the public uses the webUI to access the last public link created by user "Alice" in a new session
+    And the user closes the text editor using the webUI
     Then file "lorem.txt" should be listed on the webUI as single share
 
   @smokeTest @ocisSmokeTest @issue-ocis-reva-383
@@ -38,6 +39,7 @@ Feature: Create public link shares
       | name        | Link        |
     And a link named "Link" should be listed with role "Anyone with the link can view" in the public link list of resource "lorem.txt" on the webUI
     When the public uses the webUI to access the last public link created by user "Alice" in a new session
+    And the user closes the text editor using the webUI
     Then file "lorem.txt" should be listed on the webUI as single share
 
   @skipOnOC10 @issue-ocis-reva-383
@@ -54,6 +56,7 @@ Feature: Create public link shares
       | permissions | read           |
       | path        | /simple-folder |
     When the public uses the webUI to access the last public link created by user "Alice" in a new session
+    And the user closes the text editor using the webUI
     Then file "lorem.txt" should be listed on the webUI as single share
 
   @skipOnOC10 @issue-ocis-reva-383
@@ -69,6 +72,7 @@ Feature: Create public link shares
       | permissions | read        |
       | path        | /lorem.txt  |
     When the public uses the webUI to access the last public link created by user "Alice" in a new session
+    And the user closes the text editor using the webUI
     Then file "lorem.txt" should be listed on the webUI as single share
 
   @issue-ocis-reva-389
@@ -79,6 +83,7 @@ Feature: Create public link shares
     And user "Alice" has logged in using the webUI
     When the user creates a new public link for folder "aquickbrownfoxjumpsoveraverylazydogaquickbrownfoxjumpsoveralazydog" using the webUI
     And the public uses the webUI to access the last public link created by user "Alice" in a new session
+    And the user closes the text editor using the webUI
     Then file "lorem.txt" should be listed on the webUI as single share
 
 

tests/acceptance/features/webUISharingPublicBasic/publicLinkEdit.feature

@@ -69,6 +69,7 @@ Feature: Edit public link shares
       | password    | pass123       |
     When the user renames the public link named "Public-link" of folder "simple-folder" to "simple-folder Share"
     And the public uses the webUI to access the last public link created by user "Alice" with password "pass123" in a new session
+    And the user closes the text editor using the webUI
     Then file "lorem.txt" should be listed on the webUI as single share
 
 
@@ -83,6 +84,7 @@ Feature: Edit public link shares
     And user "Alice" has logged in using the webUI
     When the user tries to edit the public link named "Public-link" of folder "simple-folder" changing the password to "qwertyui"
     And the public uses the webUI to access the last public link created by user "Alice" with password "qwertyui" in a new session
+    And the user closes the text editor using the webUI
     Then file "lorem.txt" should be listed on the webUI as single share
 
   @issue-3830
@@ -110,6 +112,7 @@ Feature: Edit public link shares
     And user "Alice" has logged in using the webUI
     When the user tries to edit the public link named "Public-link" of folder "simple-folder" changing the role to "Viewer"
     And the public uses the webUI to access the last public link created by user "Alice" in a new session
+    And the user closes the text editor using the webUI
     Then file "lorem.txt" should be listed on the webUI as single share
     And it should not be possible to delete file "lorem.txt" as single share using the webUI
 
@@ -156,6 +159,7 @@ Feature: Edit public link shares
     And user "Alice" has logged in using the webUI
     When the user tries to edit the public link named "Public-link" of folder "simple-folder" changing the role to "Contributor"
     And the public uses the webUI to access the last public link created by user "Alice" in a new session
+    And the user closes the text editor using the webUI
     And the user uploads file "lorem.txt" using the webUI
     Then file "simple.txt" should be listed on the webUI
     And file "lorem.txt" should be listed on the webUI
@@ -169,4 +173,5 @@ Feature: Edit public link shares
     And user "Alice" has logged in using the webUI
     When the user tries to edit the public link named "Public-link" of folder "lorem.txt" adding a password "pass123"
     And the public uses the webUI to access the last public link created by user "Alice" with password "pass123" in a new session
+    And the user closes the text editor using the webUI
     Then file "lorem.txt" should be listed on the webUI as single share

tests/acceptance/features/webUISharingPublicBasic/publicLinkPublicActions.feature

@@ -12,6 +12,7 @@ Feature: Access public link shares by public
   Scenario: public should be able to access a public link with correct password
     Given user "Alice" has created file "simple-folder/lorem.txt" in the server
     And user "Alice" has shared folder "simple-folder" with link with "read, update, create, delete" permissions and password "pass123" in the server
+    And the user closes the text editor using the webUI
     When the public uses the webUI to access the last public link created by user "Alice" with password "pass123" in a new session
     Then file "lorem.txt" should be listed on the webUI as single share
 

tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature

@@ -27,6 +27,7 @@ Feature: Share by public link with different roles
     #   | name        | Link           |
     # And a link named "Link" should be listed with role "<role>" in the public link list of folder "simple-folder" on the webUI
     When the public uses the webUI to access the last public link created by user "Alice" in a new session
+    And the user closes the text editor using the webUI
     Then file "lorem.txt" should be listed on the webUI as single share
     Examples:
       | role   | permissions |
@@ -47,6 +48,7 @@ Feature: Share by public link with different roles
       | name        | Link           |
     And a link named "Link" should be listed with role "<displayed-role>" in the public link list of folder "simple-folder" on the webUI
     When the public uses the webUI to access the last public link created by user "Alice" in a new session
+    And the user closes the text editor using the webUI
     Then file "lorem.txt" should be listed on the webUI as single share
     Examples:
       | role        | displayed-role                  | permissions                  |
@@ -68,6 +70,7 @@ Feature: Share by public link with different roles
       | permissions | <permissions>  |
       | path        | /simple-folder |
     When the public uses the webUI to access the last public link created by user "Alice" in a new session
+    And the user closes the text editor using the webUI
     Then file "lorem.txt" should be listed on the webUI as single share
     Examples:
       | role        | permissions                  |
@@ -156,13 +159,15 @@ Feature: Share by public link with different roles
     Given user "Alice" has created file "simple-folder/lorem.txt" in the server
     And user "Alice" has shared folder "simple-folder" with link with "read" permissions in the server
     When the public uses the webUI to access the last public link created by user "Alice" in a new session
+    And the user closes the text editor using the webUI
     Then it should not be possible to delete file "lorem.txt" as single share using the webUI
 
 
   Scenario: creating a public link with "Editor" role makes it possible to upload a file
     Given user "Alice" has shared folder "simple-folder" with link with "read, update, create, delete" permissions in the server
     When the public uses the webUI to access the last public link created by user "Alice" in a new session
     And the user uploads file "new-lorem.txt" using the webUI
+    And the user closes the text editor using the webUI
     Then file "new-lorem.txt" should be listed on the webUI as single share
     And as "Alice" file "simple-folder/new-lorem.txt" should exist in the server
 
@@ -203,10 +208,10 @@ Feature: Share by public link with different roles
     Given user "Alice" has shared folder "simple-folder" with link with "read, update, create, delete" permissions and password "pass123" in the server
     When the public uses the webUI to access the last public link created by user "Alice" with password "pass123" in a new session
     And the user uploads file "new-lorem.txt" using the webUI
+    And the user closes the text editor using the webUI
     Then file "new-lorem.txt" should be listed on the webUI as single share
     And as "Alice" file "simple-folder/new-lorem.txt" should exist in the server
 
-
   Scenario: creating a public link with "Editor" role makes it possible to upload files inside a subdirectory
     Given user "Alice" has created folder "simple-folder/simple-empty-folder" in the server
     And user "Alice" has shared folder "simple-folder" with link with "read, update, create, delete" permissions in the server

tests/acceptance/features/webUISharingPublicManagement/shareByPublicLink.feature

@@ -77,6 +77,7 @@ Feature: Public link share management
     And user "Alice" has logged in using the webUI
     When the user copies the url of public link named "Public-link" of folder "simple-folder" using the webUI
     And the user navigates to the copied public link using the webUI
+    And the user closes the text editor using the webUI
     Then file "lorem.txt" should be listed on the webUI as single share
 
 
@@ -131,6 +132,7 @@ Feature: Public link share management
       | name        | public link |
       | permissions | read        |
     When the public uses the webUI to access the last public link created by user "Alice" in a new session
+    And the user closes the text editor using the webUI
     Then file "lorem.txt" should be listed on the webUI as single share
     And the create button should not be visible on the webUI