Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] 9.4.1.1 Correct syntax #10737

Closed
2 tasks
tschiebel opened this issue Apr 5, 2024 · 3 comments
Closed
2 tasks

[a11y] 9.4.1.1 Correct syntax #10737

tschiebel opened this issue Apr 5, 2024 · 3 comments
Assignees
Labels
Priority:p3-medium Normal priority Topic:Accessibility Type:Bug Something isn't working

Comments

@tschiebel
Copy link

audit: https://infinite.owncloud.com/s/PnaAukHGGsLnrMM

https://bitvtest.de/pruefschritt/bitv-20-web/bitv-20-web-9-4-1-1-korrekte-syntax

The check was carried out with HTTP Validator (https://validator.w3.org/nu) via the Chrome
extension "ARC Toolkit". The results were filtered with "Check for WCAG 2.0 parsing
compliance" (see: https://validator.w3.org/nu/about.html#extras).
Only WCAG-relevant errors were taken into account, i.e. the following must be guaranteed for each element
the following must be guaranteed:
a) They have complete start and end tags
b) They are correctly nested according to the specification
c) They do not contain any duplicate attributes
d) All their IDs are unique, except where the specifications allow otherwise.

Personal

  • If you open the detail view of a file and then go to the "Shares" area,
    duplicate IDs appear in the code. This affects both the button "Show invited
    people" button and the "Show links" button.

Shares

  • The ID "resource-table-select-all" is used several times on the page. To ensure
    correct functionality, each ID on the page should be unique.
@tschiebel tschiebel added Type:Bug Something isn't working Priority:p3-medium Normal priority Topic:Accessibility labels Apr 5, 2024
@pascalwengerter
Copy link
Contributor

The three occurances of "resource-table-select-all" were from a time when accepted/declined/pending shares were present in three separate tables on the same page, which has been resolved via #9718

@pascalwengerter
Copy link
Contributor

duplicate IDs for status indicators have also long been fixed from what I can see in statusIndicator.ts

@kulmann
Copy link
Member

kulmann commented Jun 20, 2024

Check it as well, both issues solved:

  • indicator ids get the file id as suffix, making them unique
  • Shares page doesn't contain 3 ResourceTables anymore, but only 1, thus the select all id is unique on the Shares page

@kulmann kulmann closed this as completed Jun 20, 2024
@tbsbdr tbsbdr added this to the Web Accessibility milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Topic:Accessibility Type:Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants