Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared with me: Show / Hide shares (#9531) #9718

Merged
merged 13 commits into from
Oct 30, 2023
Merged

Shared with me: Show / Hide shares (#9531) #9718

merged 13 commits into from
Oct 30, 2023

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter commented Sep 20, 2023 •
edited by JammingBen
Loading

Related Issue

Waiting for cs3org/reva#4194 to make its way into oCIS needs owncloud/owncloud-sdk#1246 merged and published (as well as potential another update to the SDK)

image

@update-docs
Copy link

update-docs bot commented Sep 20, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen
Copy link
Collaborator

JammingBen commented Oct 19, 2023 •
edited
Loading

Pipeline is green and everything works for now.

However, the server is currently reworking some things, so this needs another iteration once cs3org/reva#4256 is resolved. The only thing that needs to change is probably the request for hiding shares, which will be a PUT. Also, the param hide will be renamed to hidden.

Our implementation is now complete, although there still is a server issue: owncloud/ocis#7589

@JammingBen JammingBen force-pushed the feature/9531 branch 2 times, most recently from dfabb67 to 24bc42c Compare October 26, 2023 10:02
@JammingBen JammingBen marked this pull request as ready for review October 26, 2023 11:58
@AlexAndBear
Copy link
Contributor

AlexAndBear commented Oct 26, 2023 •
edited
Loading

So far so good.

Some things I noticed

  • 'No shares' dialog is not centered on y axis
    image

  • Hide action not in context menu, is this on purpose?
    image

  • If I have a hidden share and click disabled sync, it moves from hidden shares to (visible) shares, is this on purpose? Feels somehow weird to me (as I can move disabled sync shares to hidden anyways)

  • Is it possible to have a small sync icon loop-right-fill next to the (sync) status, because otherwise I feel the cloud icon on its own is not descriptive enough (similar to the postprocessing indicator, next to the file icon)
    image

AlexAndBear
AlexAndBear requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Center no item message

@JammingBen
Copy link
Collaborator

@janackermann Thx for the feedback, I implemented all your suggestions, except for:

If I have a hidden share and click disabled sync, it moves from hidden shares to (visible) shares, is this on purpose? Feels somehow weird to me (as I can move disabled sync shares to hidden anyways)

That is a known backend limitation currently.

Is it possible to have a small sync icon loop-right-fill next to the (sync) status, because otherwise I feel the cloud icon on its own is not descriptive enough (similar to the postprocessing indicator, next to the file icon)

I agree, also Tobi and CERN suggested to use a different icon here, which I totally forgot about. So it is `loop-right´ now.

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

55.6% 55.6% Coverage
7.8% 7.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

AlexAndBear
AlexAndBear approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@JammingBen JammingBen merged commit 92ce89a into owncloud:master Oct 30, 2023
3 of 4 checks passed
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@pascalwengerter @JammingBen @AlexAndBear
Shared with me: Show / Hide shares (#9531) (#9718)
7d7431d 
* Next iteration of share show/hide

* Rebase and add changelog item

* put remaining parts together to make it work

* fixup! put remaining parts together to make it work

* keep original action names internally for accepting/declining shares

* test: fix tests

* do not allow decline action on pending shares

* feat: rename hide to hidden, use PUT for the request to set it

* fix: center no-content-message for shared-with-me-section

* feat: add action to hide shares to context menu

* fix: ensure the share hidden-param does not get sent when not needed

* fix pipeline

---------

Co-authored-by: Jannik Stehle <jannik.stehle@gmail.com>
@pascalwengerter pascalwengerter deleted the feature/9531 branch January 18, 2024 18:06
@pascalwengerter pascalwengerter mentioned this pull request Apr 16, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web] Shared with me: Show / Hide shares
3 participants
@pascalwengerter @JammingBen @AlexAndBear