Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for adding numerical tags on a resource #11195

Closed
1 task
PrajwolAmatya opened this issue Jul 16, 2024 · 2 comments
Closed
1 task

Add e2e test for adding numerical tags on a resource #11195

PrajwolAmatya opened this issue Jul 16, 2024 · 2 comments
Labels

Comments

@PrajwolAmatya
Copy link
Contributor

PrajwolAmatya commented Jul 16, 2024

Description

When a tag is added on a resource and the page is reloaded then the resource gets lost and oCIS stops working.
Related issue mentioned here: #11193

We do have test cases for adding tags on a resource but not the numerical tags.

  • Add e2e for adding numerical tags, e.g. 1234, to a resource. tests/e2e/cucumber/features/smoke/tags.feature
@PrajwolAmatya PrajwolAmatya transferred this issue from owncloud/ocis Jul 16, 2024
@PrajwolAmatya PrajwolAmatya changed the title Add test cases for adding numerical tags on a resource Add e2e test for adding numerical tags on a resource Jul 16, 2024
@kulmann
Copy link
Member

kulmann commented Jul 17, 2024

Please don't create an e2e test for this. Should only be a unit test on the resource building.

Reason: we agreed to not test edge cases in e2e tests anymore. Only happy path tests.

@PrajwolAmatya
Copy link
Contributor Author

Please don't create an e2e test for this. Should only be a unit test on the resource building.

Reason: we agreed to not test edge cases in e2e tests anymore. Only happy path tests.

Yes, sure. I will close this issue. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants