numerical tags causes serious problem!

[nazarifard]

if user add number as a tag to one folder, the folder will be missed entirely!
for example; adding 1234 as a tag will cause the resource disappear totally.

[phil-davis]

@PrajwolAmatya do we have some test coverage for tags, and the case where a tag is numeric?

[nazarifard]

@PrajwolAmatya do we have some test coverage for tags, and the case where a tag is numeric?

Yes, just assign a 1234 as a tag to a folder and press enter. I can't show the result because OCIS doesn't work after this case and can't show the parent folder that contains any resource with numeric tags!

[nazarifard]

after refresh the page, OCIS can't find the resource.

[PrajwolAmatya]

@PrajwolAmatya do we have some test coverage for tags, and the case where a tag is numeric?

I can reproduce this, adding numeric tag and refreshing the page the oCIS stops working.
We do have test cases for tags but not specifically with the numerical tags. I will create a separate issue to add tests for adding numeric tags to a resource.

[kobergj]

Awesome. You loose your complete personal space if you add numerical tags to a resource. Works also in project spaces. Needs a fix asap.

[kobergj]

Web throws error:

TypeError: (e.props[D.Tags] || "").split is not a function

[nazarifard]

Awesome. You loose your complete personal space if you add numerical tags to a resource. Works also in project spaces. Needs a fix asap.

I fixed the issue independently, However first part is also fixed by @AlexAndBear
But I think it's a It is the tip of the iceberg, likely at least all property of DavPropertyMapping should be double checked.

[nazarifard]

Hi @AlexAndBear
I sent a new PR to fix the issue, but seemingly there is a issue in TestFunctions and my PR is blocked. Can you review the source and or Unit Test functions. I tested locally and my codes is working fine without any issue.

#11197

[AlexAndBear]

@nazarifard
Looks like the CI is green, I don't see any failing tasks.
Thank you very much, merged.