Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview feature makes the app unresponsive #12108

Closed
nabim777 opened this issue Jan 17, 2025 · 4 comments · Fixed by #12112
Closed

Preview feature makes the app unresponsive #12108

nabim777 opened this issue Jan 17, 2025 · 4 comments · Fixed by #12112
Assignees
Labels
Type:Bug Something isn't working

Comments

@nabim777
Copy link
Member

nabim777 commented Jan 17, 2025

Describe the bug

The UI freezes or becomes unresponsive when using the Preview feature.

Steps to reproduce

  1. Upload an image test.png
  2. Open the image test.png
  3. Using the sidebar, navigate to the actions section
  4. When a user clicks the preview and closes the image

Expected behavior

The preview should work without affecting the UI.

Actual behavior

The UI freezes or becomes unresponsive after closing the image

Screencast.from.01-17-2025.12.55.58.PM.webm

Tested on

Infinite Scale 7.1.0-rc.1 Community
ownCloud Web UI 11.1.0

@nabim777 nabim777 added the Type:Bug Something isn't working label Jan 17, 2025
@saw-jan
Copy link
Member

saw-jan commented Jan 17, 2025

^ @LukasHirt

@LukasHirt LukasHirt self-assigned this Jan 17, 2025
@LukasHirt LukasHirt moved this from Qualification to In progress in Infinite Scale Team Board Jan 17, 2025
@LukasHirt
Copy link
Collaborator

When a user clicks the preview and closes the image

By this, you mean that the user clicks on the "Preview" action in the sidebar?

Image

@saw-jan
Copy link
Member

saw-jan commented Jan 17, 2025

yeah. looks like it

@LukasHirt
Copy link
Collaborator

Ok, the bug was introduced in #12040 When clicking on the Preview action and then closing the editor, it actually does not close it but goes back to the editor again because the Preview action adds another editor route into the history. However, somehow it drops the context query causing the UI freeze.

Fixing the bug is very simple as I only need to add a check whether the context query is there and if not, do not try to access the hidden state. I would like to fix the underlying issue first though because even if the UI does not freeze, it still requires the user to click twice on the close button to actually close the editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants