Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hidden shares in preview app #12040

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

LukasHirt
Copy link
Collaborator

We've fixed the issue with displaying hidden files when user open a file in preview app in "Shared with me" list. The q_share-visibility query param is now passed to the app so that if a user opens a file while listing "visible shares", the preview app will allow moving only to another visible files. When the q_share-visibility query param is set to hidden (i.e. user is listing "hidden shares"), the preview app will allow moving only to another hidden files.

Description

We've fixed the issue with displaying hidden files when user open a file in preview app in "Shared with me" list.
The q_share-visibility query param is now passed to the app so that if a user opens a file while listing "visible shares", the preview app will allow moving only to another visible files.
When the q_share-visibility query param is set to hidden (i.e. user is listing "hidden shares"), the preview app will allow moving only to another hidden files.

Related Issue

Motivation and Context

Display only what the user would expect to see.

How Has This Been Tested?

  • test environment: local & 🤖
  • test case 1: added unit tests
  • test case 2: manual test in chrome

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

We've fixed the issue with displaying hidden files when user open a file in preview app in "Shared with me" list.
The `q_share-visibility` query param is now passed to the app so that if a user opens a file while listing "visible shares", the preview app will allow moving only to another visible files.
When the `q_share-visibility` query param is set to `hidden` (i.e. user is listing "hidden shares"), the preview app will allow moving only to another hidden files.
@LukasHirt LukasHirt requested review from kobergj and saw-jan December 16, 2024 11:04
@LukasHirt LukasHirt self-assigned this Dec 16, 2024
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Confirmed the fix

@LukasHirt LukasHirt merged commit 7a4145e into master Dec 16, 2024
4 checks passed
@LukasHirt LukasHirt deleted the fix/hidden-shares-in-preview-app branch December 16, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

User can see hidden files in the preview app on Shared with me page
2 participants