Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate app switcher from app specific navigation #2650

Closed
2 tasks done
PVince81 opened this issue Dec 9, 2019 · 5 comments · Fixed by #2669
Closed
2 tasks done

Separate app switcher from app specific navigation #2650

PVince81 opened this issue Dec 9, 2019 · 5 comments · Fixed by #2669
Assignees
@PVince81

Comments

@PVince81
Copy link
Contributor

PVince81 commented Dec 9, 2019 •
edited
Loading

Currently the left sidebar contains both app switch links and app specific navigation

As we intend to make the top bar reusable by any OCIS frontend app, we need to separate them.

  • The app switcher will become part of the top-bar component.
  • The app specific navigation will become part of the design system, and be used directly by the future phoenix-files app.

See owncloud/owncloud-design-system#532 for a possible design

Tasks
@PVince81 PVince81 added this to the Milestone 1: Phoenix for users milestone Dec 9, 2019
@PVince81 PVince81 self-assigned this Dec 9, 2019
@PVince81
Copy link
Contributor Author

PVince81 commented Dec 9, 2019

Also see the micro-frontends ticket as this falls into the same category.

@PVince81 PVince81 mentioned this issue Dec 10, 2019
Merged
20 tasks
@PVince81
Copy link
Contributor Author

PR here: #2669

@DeepDiver1975
Copy link
Member

config has bee specified already in #2573 - first section

@PVince81
Copy link
Contributor Author

PVince81 commented Dec 11, 2019 •
edited
Loading

okay. at first I had a separate file and I remembered a discussion about having it "in the config", but maybe I misunderstood. Having it in a separate file / endpoint is fine, I can bring this back.

ok, config in config.json but with the proposed schema

This was referenced Dec 11, 2019
Closed
Merged
@PVince81
Copy link
Contributor Author

next steps: #2746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PVince81 PVince81

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Separate app switcher from app navigation sidebar owncloud/web
2 participants
@PVince81 @DeepDiver1975