Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Feature/new menu topbar idea 1 #532

Closed
wants to merge 3 commits into from

Conversation

DeepDiver1975
Copy link
Member

Screenshot from 2019-11-07 13-11-49

@DeepDiver1975
Copy link
Member Author

Also with app menu like google - as an idea to discuss
Screenshot from 2019-11-07 13-54-33

@wuenschedesign wuenschedesign self-assigned this Nov 8, 2019
@PVince81
Copy link
Contributor

PVince81 commented Dec 5, 2019

@wuenschedesign can you review the proposal ? (you might want to ignore the visual flaws as this was done quickly)

I think this is the way to go, we need to separate the files app entries from the actual application entries as it will fit better with the way we want to do Phoenix extensions in the future.

Basically the header and the application menu will be reused also in OC 10 to provide a seamless experience.

@PVince81
Copy link
Contributor

PVince81 commented Dec 5, 2019

I've started splitting the menus already in owncloud/web#2620.
In that one I've kept the left sidebar to slide in as before, not sure if this should change as well in the new design to have it always visible like in OC 10 ?

@PVince81
Copy link
Contributor

PVince81 commented Dec 10, 2019

PR that implements this in Phoenix: owncloud/web#2669

Next todos for this design system PR:

  • Fix the menu button styles
  • Proper icon for app switcher, also important to be expose it to Phoenix to use it there

@DeepDiver1975
Copy link
Member Author

So I guess we no longer need this?
Or shall we create the components (user menu, app switcher, nav bar etc ....) within ods?

@PVince81
Copy link
Contributor

We need at least this PR as it contains the "example page" with some markup and styles, which I used as inspiration for the actual implementation.

Not sure if we need smaller design system components, it feels a bit like overkill considering that these components will only be used in one place (in the top-bar vue / web component)

@PVince81
Copy link
Contributor

  • revert file list changes and keep only top bar changes

@PVince81 PVince81 assigned PVince81 and unassigned DeepDiver1975 Dec 11, 2019
@PVince81
Copy link
Contributor

@PVince81 PVince81 mentioned this pull request Dec 11, 2019
3 tasks
@PVince81
Copy link
Contributor

Superseded by #568 which only picks the top bar changes

@PVince81 PVince81 closed this Dec 11, 2019
@pascalwengerter pascalwengerter deleted the feature/new-menu-topbar-idea-1 branch March 17, 2021 07:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants