Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new file + extension point #274

Closed
DeepDiver1975 opened this issue Oct 12, 2018 · 12 comments
Closed

Create new file + extension point #274

DeepDiver1975 opened this issue Oct 12, 2018 · 12 comments
Assignees

Comments

@DeepDiver1975
Copy link
Member

DeepDiver1975 commented Oct 12, 2018

Story:
Given a phoenix plugin registers a new file action for text files
And a user is logged in
When the user clicks on new file action (UX to be defined)
Then a dialog/context pops up which lists new files including for text files

When the user enters the new file name and hits enter
Then phoenix core creates the file
And the app code is triggered which opens the file in some editor

Related to #215

Tasks:
same as with #215

  • Additional effort in phoenix core (1MD)
@PVince81 PVince81 mentioned this issue Oct 12, 2018
17 tasks
@DeepDiver1975
Copy link
Member Author

  • creating new files is already done
  • handler registration to open the file right away is missing

@DeepDiver1975 DeepDiver1975 added this to the backlog milestone Jan 11, 2019
@PVince81
Copy link
Contributor

We're also missing the extension point to allow for apps to provide additional file types.
For example:

  • create text file
  • create ODT document
  • ...

@PVince81 PVince81 modified the milestones: backlog, Milestone 1: Phoenix for users Sep 24, 2019
@PVince81
Copy link
Contributor

  • add extension point for other apps to register their types
  • automatically open the file after creation, if the type is known

@PVince81
Copy link
Contributor

From a design POV, for now the easiest is to append whatever registered file types are available directly into the dropdown. Any other UX would be more time costy and require thinking about maybe selecting the file type inside the dialog prompt, or something else.

@PVince81 PVince81 changed the title Create new file Create new file + extension point Sep 26, 2019
@DeepDiver1975 DeepDiver1975 self-assigned this Sep 27, 2019
@DeepDiver1975
Copy link
Member Author

is this what we want to have? @PVince81 @pmaier1 @LukasHirt

Screenshot from 2019-09-27 11-49-26

@LukasHirt
Copy link
Collaborator

I'm not really a fan of how huge is the dropdown becoming but as @PVince81 wrote

Any other UX would be more time costy

For now 👍 from me. Let's invest more time later to find a better way.

@DeepDiver1975
Copy link
Member Author

The way we are building this has an impact on the api on how apps register themselves ... as far as I can tell ...
So we need to accept some duplicate effort here ....

@PVince81
Copy link
Contributor

We could also raise the priority for getting design input on this item before desigining the API.

From my POV it will mostly be about registering an icon, a text and an action handler.

@DeepDiver1975
Copy link
Member Author

the text will be interesting - in case of menu entry (like above) - the api requires a function which returns the translated full text.
'New Microsoft Word document..' -> 'Neues Microsoft Word Dokument...'

We cannot translate only parts of the text.

In case we go for a different approach the text appears in a different context and might look totally different.

@PVince81
Copy link
Contributor

Indeed. But to prevent blocking ourselves we could call this extension point "beta" or "tech preview" to have no stability guarantee but still allow prototyping. The text is likely the least difficult part.

@DeepDiver1975
Copy link
Member Author

with #2111 being merged - can we close this - or am I missing anything? THX
@PVince81 @LukasHirt

@LukasHirt
Copy link
Collaborator

can we close this

IMO yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants