-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new file + extension point #274
Comments
|
We're also missing the extension point to allow for apps to provide additional file types.
|
|
From a design POV, for now the easiest is to append whatever registered file types are available directly into the dropdown. Any other UX would be more time costy and require thinking about maybe selecting the file type inside the dialog prompt, or something else. |
is this what we want to have? @PVince81 @pmaier1 @LukasHirt |
I'm not really a fan of how huge is the dropdown becoming but as @PVince81 wrote
For now 👍 from me. Let's invest more time later to find a better way. |
The way we are building this has an impact on the api on how apps register themselves ... as far as I can tell ... |
We could also raise the priority for getting design input on this item before desigining the API. From my POV it will mostly be about registering an icon, a text and an action handler. |
the text will be interesting - in case of menu entry (like above) - the api requires a function which returns the translated full text. We cannot translate only parts of the text. In case we go for a different approach the text appears in a different context and might look totally different. |
Indeed. But to prevent blocking ourselves we could call this extension point "beta" or "tech preview" to have no stability guarantee but still allow prototyping. The text is likely the least difficult part. |
with #2111 being merged - can we close this - or am I missing anything? THX |
IMO yes |
Story:
Given a phoenix plugin registers a new file action for text files
And a user is logged in
When the user clicks on new file action (UX to be defined)
Then a dialog/context pops up which lists new files including for text files
When the user enters the new file name and hits enter
Then phoenix core creates the file
And the app code is triggered which opens the file in some editor
Related to #215
Tasks:
same as with #215
The text was updated successfully, but these errors were encountered: