Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new file menu entries for different file types. #2111

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Add new file menu entries for different file types. #2111

merged 1 commit into from
Oct 23, 2019

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Oct 1, 2019 •
edited
Loading

Description

App can register new file handlers

Related Issue

Screenshots (if appropriate):

Screenshot from 2019-10-01 12-42-53
Screenshot from 2019-10-01 12-43-12

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@DeepDiver1975 DeepDiver1975 added the Status:Needs-Review Needs review from a maintainer label Oct 1, 2019
@DeepDiver1975 DeepDiver1975 self-assigned this Oct 1, 2019
@ownclouders
Copy link
Contributor

💥 Acceptance tests webUILogin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5364/

20191001-110123-507.png
20191001-110146-162.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUITrashbin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5385/

20191001-141719-797.png
20191001-141745-172.png
20191001-141745-375.png

@PVince81
Copy link
Contributor

PVince81 commented Oct 8, 2019

there are conflicts to fix

PVince81
PVince81 reviewed Oct 8, 2019
View reviewed changes
apps/files/src/mixins.js
}
return
}
// TODO: rewire code below ....
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raise tickets for these ?

PVince81
PVince81 reviewed Oct 8, 2019
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments and resolve the confcts

PVince81
PVince81 approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DeepDiver1975 DeepDiver1975 merged commit 57636b4 into master Oct 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/new-file-menu branch October 23, 2019 15:20
@DeepDiver1975 DeepDiver1975 mentioned this pull request Oct 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@LukasHirt LukasHirt Awaiting requested review from LukasHirt

Assignees

@DeepDiver1975 DeepDiver1975

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DeepDiver1975 @ownclouders @PVince81