Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roles select must be limited to disallow permission increases #2963

Closed
PVince81 opened this issue Feb 5, 2020 · 3 comments · Fixed by #7015
Closed

Roles select must be limited to disallow permission increases #2963

PVince81 opened this issue Feb 5, 2020 · 3 comments · Fixed by #7015
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@PVince81
Copy link
Contributor

PVince81 commented Feb 5, 2020

Steps

  1. Create three users "Alice", "Bob" and "Charlie"
  2. Login as "Alice"
  3. Create a folder "test"
  4. Share "test" with "Bob" with the "Viewer" role, and allow re-sharing
  5. Login as "Bob"
  6. Share "test" with "Charlie" with "Editor" permissions

Expected result

The roles dropdown should not allow selecting anything else than "Viewer".
Maybe if there's only a single entry, don't even show the dropdown and keep a single entry.
Maybe grey out the other entries in the dropdown so we know they exist but cannot be selected.

Actual result

All entries are visible and can be selected.
Saving will leave the dialog with an error "Cannot set the requested share permissions for test".

Side note: when catching such error in general, the "add collaborator" dialog must not disappear!

Version

v0.3.0

@kulmann FYI as we observed this during our recent work.

cc @pmaier1

@PVince81 PVince81 added the Type:Bug Something isn't working label Feb 14, 2020
@kulmann kulmann added the Priority:p1-urgent Consider a hotfix release with only that fix label Dec 3, 2021
@kulmann
Copy link
Member

kulmann commented Dec 3, 2021

Wait with implementation until #6039 is merged

@kulmann kulmann added Priority:p2-high Escalation, on top of current planning, release blocker and removed Priority:p1-urgent Consider a hotfix release with only that fix labels Dec 13, 2021
@AlexAndBear
Copy link
Contributor

Resharing seems not to be allowed anymore, so is this still an issue?

image

@pascalwengerter
Copy link
Contributor

pascalwengerter commented May 17, 2022

Resharing seems not to be allowed anymore, so is this still an issue?

image

Yes, resharing is part of the roadmap (ideally this week in oCIS)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants