Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Unify people sharing sidebar (no panels, inline sharee editing) #6039

Merged
merged 66 commits into from
Dec 20, 2021
Merged

[full-ci] Unify people sharing sidebar (no panels, inline sharee editing) #6039

merged 66 commits into from
Dec 20, 2021

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter commented Nov 19, 2021 •
edited by kulmann
Loading

Description

Move invite form into the people sharing main panel and introduce inline editing for existing shares (instead of an edit subpanel).

Related Issue

Motivation and Context

See linked issues

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • release ODS with Add padding size for OcDrop owncloud-design-system#1798 being merged, update ODS in this PR (needed for padding size in OcDrop)
  • reload bitmaskToRole mapping for the sharee ListItem after updating a share (i.e. show read+share permissions as Viewer, not as Custom permissions)
  • fix that updating a role clears the expiration date
  • fix inline expiration date modifications flakyness
  • remove tests which are not applicable anymore (mostly the fact the we showed the owner if the sharee list before and don't do that anymore in this PR intentionally)
  • implement todo unit tests in RoleDropdown.spec.js
  • fix unit tests in FileShares.spec.js @pascalwengerter
  • implement todo unit tests in InviteCollaboratorForm.spec.js
  • implement todo unit tests in RecipientContainer.spec.js
  • implement todo unit tests in ExpirationDatepicker.spec.js
  • fix integration tests @kulmann
  • fix acceptance tests

@pascalwengerter pascalwengerter changed the title [full-ci] Unify people sharing sidebar to always contain createSharee [full-ci] Unify people sharing sidebar (no panels, inline sharee editing) Nov 19, 2021
@pascalwengerter pascalwengerter mentioned this pull request Nov 19, 2021
Closed
5 tasks
@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/20395/16/1
The following scenarios passed on retry:

  • webUISharingAcceptSharesToRoot/acceptShares.feature:108

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/20395/17/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:15

@ownclouders
Copy link
Contributor

Results for oC10SharingPublicExpireAndRoles https://drone.owncloud.com/owncloud/web/20409/38/1
The following scenarios passed on retry:

  • webUISharingPublicExpire/shareByPublicLinkExpiringLinks.feature:11

@pascalwengerter pascalwengerter force-pushed the unify-people-share-sidebar branch 4 times, most recently from aad2af5 to 1f4ef64 Compare November 22, 2021 17:51
This was referenced Nov 23, 2021
Closed
Closed
lookacat
lookacat reviewed Nov 24, 2021
View reviewed changes
packages/web-app-files/src/components/SideBar/Shares/NewCollaborator/Form.vue Outdated

export default {
name: 'NewCollaborator',
name: 'NewCollaboratorForm',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like NewCollaboratorForm, but should we name the file accordingly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can take care of that! Any other suggestions regarding naming? I'm not 100% happy with what I've got so far

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe AddNewCollaboratorForm?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... or InviteCollaboratorForm?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that sounds good, I would also rename the folder from NewCollaborator to InviteCollaborator sounds more intuitive

@kulmann kulmann force-pushed the unify-people-share-sidebar branch 2 times, most recently from 3147e7b to f09e684 Compare November 25, 2021 13:48
@ownclouders
Copy link
Contributor

Results for oC10SharingInternalGroups https://drone.owncloud.com/owncloud/web/20480/26/1
The following scenarios passed on retry:

  • webUISharingInternalGroups/shareWithGroups.feature:166

kulmann and others added 17 commits December 15, 2021 17:39
@kulmann
disable people expiration dates for e2e ci run
295d6e7
@pascalwengerter
Implement RecipientContainer unit tests
695405d
@pascalwengerter
Reduce files app unit test warnings
bf645e4
@pascalwengerter
Fix test fixtures & run one expirationDate integration test
0bfbc81
@kulmann
Make linter happy
abd3032
@fschade
fix integration tests
8035491
@pascalwengerter
Remove experimental part of smoke-acceptance-test command in CI
8d53661
@pascalwengerter
Fix smokeTest sharing in shares sidebar
96d38dc
@kulmann
Fix custom permission selection in e2e tests
8d997cc
@kulmann
Fix alignments in people sharing
7159642
@kulmann
Fix more e2e tests regarding sharing
fd37aee
@pascalwengerter
Fix AutocompleteItem test
a3d0ef2
@pascalwengerter
Merge branch 'master' into unify-people-share-sidebar
ba56011
@kulmann
fix small sharing info e2e tests
b09c774
@pascalwengerter
Update expected failures, fix link expiry date checker
1bfbc59
@pascalwengerter
Mitigate nonexistent group share expiry in oCIS, resolve (un)expected…
127a38b 
… failures
@kulmann
Fix some more acceptance tests
d787b72
@sonarcloud
Copy link

sonarcloud bot commented Dec 20, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

56.3% 56.3% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/21207/15/1
The following scenarios passed on retry:

  • webUISharingAcceptSharesToRoot/acceptShares.feature:108

@lookacat lookacat self-requested a review December 20, 2021 13:37
lookacat
lookacat approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge 🥇

@kulmann kulmann marked this pull request as ready for review December 20, 2021 13:40
@kulmann kulmann merged commit 156e77d into master Dec 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the unify-people-share-sidebar branch December 20, 2021 13:47
@fschade fschade mentioned this pull request Dec 20, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann left review comments

@lookacat lookacat lookacat approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees

@kulmann kulmann

Labels
None yet
Projects
No open projects
Web Support Board
Status: Done
Milestone
No milestone
5 participants
@pascalwengerter @ownclouders @lookacat @kulmann @fschade