Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove loadConfig on extensions #3726

Closed
kulmann opened this issue Jul 2, 2020 · 5 comments
Closed

Remove loadConfig on extensions #3726

kulmann opened this issue Jul 2, 2020 · 5 comments

Comments

@kulmann
Copy link
Contributor

kulmann commented Jul 2, 2020

At the moment we run a loadConfig action on external extensions, which is required in vuex-stores of all ocis-web extensions. It looks like it is obsolete now and could be removed. After that it could be removed from external extensions as well. We need to check if it is unused (afaik it is).

Loading config of external extensions happens here and is probably obsolete:
https://github.com/owncloud/phoenix/blob/f9a0874dc016ee0269c698914ef3f2c75ce3e2e6/src/store/apps.js#L52

loadConfig action in a vuex-store of an external extension (example):
https://github.com/owncloud/ocis-hello/blob/818b83724f54f1ba8b4bfb34e766f42c2942a69d/ui/store.js#L17

@pascalwengerter
Copy link
Contributor

@kulmann could you check if this can be closed since @fschade refactored the runtime boot logic quite heavily?

@kulmann
Copy link
Contributor Author

kulmann commented Nov 16, 2021

@pascalwengerter yes, he removed it (which is good) and now it can be removed in ocis/accounts, ocis/settings and ocis-hello. Do you want to take care or should I?

@pascalwengerter
Copy link
Contributor

@pascalwengerter yes, he removed it (which is good) and now it can be removed in ocis/accounts, ocis/settings and ocis-hello. Do you want to take care or should I?

Let me take a look later this week 💪🏽

@dschmidt
Copy link
Member

Anything still missing after those two PRs have been merged?

@kulmann
Copy link
Contributor Author

kulmann commented Feb 16, 2022

Afaik no, thank you for keeping track of it... and of course for fixing it 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants