Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ocis-web server url #81

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Use ocis-web server url #81

merged 2 commits into from
Jul 2, 2020

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Jul 2, 2020

We are not providing an api url anymore but use the server url from ocis-web config instead. This still - as before - requires that ocis-proxy is in place for routing API requests to ocis-hello.

kulmann added 2 commits July 2, 2020 08:38
Instead of using a hardcoded API url in the web ui, this commit switches
to using the ocis-web server url instead. This - as before - requires
that ocis-proxy is in place for routing the API requests to ocis-hello.
@kulmann kulmann requested a review from LukasHirt July 2, 2020 06:42
@kulmann kulmann self-assigned this Jul 2, 2020
Copy link
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole loadConfig logic could be IMHO removed from both here and the related logic in ocis-web. This was a temporary solution for having an extension-specific config before there was settings service. But since the service exists now, I don't see a use case for the config in here.

@kulmann
Copy link
Contributor Author

kulmann commented Jul 2, 2020

The whole loadConfig logic could be IMHO removed from both here and the related logic in ocis-web. This was a temporary solution for having an extension-specific config before there was settings service. But since the service exists now, I don't see a use case for the config in here.

Cool, I was already wondering why we have this in ocis-web. We have to remove the call in ocis-web first and then can make pull requests on ocis-hello, ocis-settings and ocis-accounts to remove it from the vuex-stores there.

@kulmann kulmann merged commit 818b837 into master Jul 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the use-phoenix-server-url branch July 2, 2020 08:06
@kulmann
Copy link
Contributor Author

kulmann commented Jul 2, 2020

Raised an issue here owncloud/web#3726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants