Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI test for "Hide search bar" setting #3818

Closed
individual-it opened this issue Jul 24, 2020 · 1 comment · Fixed by #3824
Closed

UI test for "Hide search bar" setting #3818

individual-it opened this issue Jul 24, 2020 · 1 comment · Fixed by #3824
Labels

Comments

@individual-it
Copy link
Member

a test is needed for #3817
the main challenge here will be to edit the config json file from the test step, and maybe a reload of phoenix is needed alsoe

alternatively we can have two separate tests for OCIS & for oC10, with separate config json files as input

@kulmann
Copy link
Member

kulmann commented Jul 24, 2020

Just tested with page reload. In case you start ocis with PHOENIX_WEB_CONFIG=/path/to/config.json ./bin/ocis server it actually works without ocis restart to edit the config + see the change after a browser reload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants