Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide search bar #3817

Merged
merged 4 commits into from
Jul 24, 2020
Merged

Hide search bar #3817

merged 4 commits into from
Jul 24, 2020

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jul 24, 2020

Description

This PR introduces a new options object in config.json, with a first option hideSearchBar which is utilized to disable the search bar in ocis. Since there are no capabilities for whether or not search is possible, we chose to use the config instead.

Related Issue

Motivation and Context

Search is not implemented in ocis, so it's better to hide the search bar instead of having early adopters reporting that search doesn't work. We will bring it back as soon as search is implemented.

How Has This Been Tested?

Without the option set to true nothing changes. That is covered by tests and has been tested manually.

Screenshots (if appropriate):

Search bar at the top is hidden. This is how it looks like, with collapsed and with expanded left sidebar.
Screenshot 2020-07-24 at 08 03 17
Screenshot 2020-07-24 at 08 03 27

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Acceptance test for whether the search bar is invisible when the config option hideSearchBar is set to true

@kulmann kulmann requested a review from LukasHirt July 24, 2020 06:10
@update-docs
Copy link

update-docs bot commented Jul 24, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann
Copy link
Member Author

kulmann commented Jul 24, 2020

@individual-it could your team provide an acceptance test for this feature? How to set the config is shown in the ocis example config (config.json.sample-ocis, look at the options object). If this will happen next week, please make a separate PR.

@individual-it
Copy link
Member

issue to write acceptance test #3818

@kulmann kulmann mentioned this pull request Jul 24, 2020
63 tasks
@kulmann kulmann merged commit b8ec464 into master Jul 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the hide-search-bar branch July 24, 2020 07:50
ownclouders pushed a commit that referenced this pull request Jul 24, 2020
Merge: 732b06e adc8c75
Author: Benedikt Kulmann <benedikt@kulmann.biz>
Date:   Fri Jul 24 09:50:52 2020 +0200

    Merge pull request #3817 from owncloud/hide-search-bar

    Hide search bar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable search in ocis-web
3 participants