Update deps 2020 07 22 #409

kulmann · 2020-07-22T20:08:12Z

Disclaimer

For the purpose of this upcoming release we will do the process backwards without tagging. We will point dependencies to its latest master at a given point on time, Once the ocis release is complete, tags will be added to each extension.

Involved steps are:

start ocis-store by default

Releases:

This PR can be used to test downloads with pre-signed urls. There is a manual step involved for phoenix:

check out Use pre-signed URLs to download files web#3797
inside the phoenix dir, run

yarn install-all
yarn build-all

inside the ocis dir, run OCIS_LOG_LEVEL=debug PHOENIX_ASSET_PATH=/path/to/phoenix/dist/ go run cmd/ocis/main.go server

Debugging failing tests

Technical debt / future tasks to schedule

Tickets raised for remaining work based on this:

download through proxy causing weird error messages in log: owncloud/ocis-proxy#86
uuid is missing in the jwt token, we should probably add it as some services like ocis-thumbnails should be able to use it owncloud/ocis-proxy#87
any interaction would query the test users Alice, Brian, Carol, David and Emily. See picture => Any interaction causes all users to be queried #443
pre-signed URLs make more secure: owncloud/ocis-proxy#88
Ability to specify user name in Webdav path despite UUID mode: owncloud/ocis-reva#434
Group name vs group id in UI: Display group name instead of id at the accounts page #441
ocis-accounts changes should use channel to update files atomically: owncloud/ocis-accounts#85
simplify tracing-config for ocis-store: Add tracing config to ocis-store #445
grep the code for more potential user id calls for more possible cases
optionally: fix the ocis-ocs bug: owncloud/ocis-ocs#26 (currently disabled in [tests-only] fix tests to run with ocis/409 core#37754)
trash undelete of a folder fails, already known since beta8: Trashbin fails with unknown error when restoring product#139
random test failure with deletion: https://github.com/owncloud/ocis-reva/issues/442
decide which redigo version to use: https://github.com/owncloud/ocis/issues/448

update-docs · 2020-07-22T20:08:16Z

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

kulmann · 2020-07-23T05:36:04Z

Looking at webui tests, one can see that the login is failing on CI. Might be related to changes in ocis-accounts, needs investigation.

@individual-it did you already play around with current ocis-accounts master on CI? Are there known issues with web ui logins for tests?

individual-it · 2020-07-23T08:43:04Z

the tests are using the build in phoenix and using that I cannot login neither with the test users (einstein) not with LDAP users.
using "einstein" and no LDAP the response to the login request is:

HTTP/1.1 204 No Content
Access-Control-Allow-Origin: *
Cache-Control: no-cache, no-store, must-revalidate
Date: Thu, 23 Jul 2020 08:34:17 GMT
Expires: Thu, 01 Jan 1970 00:00:00 GMT
Kopano-Konnect-State: ezrifk
Last-Modified: Thu, 23 Jul 2020 08:34:17 GMT
Pragma: no-cache
X-Content-Type-Options: nosniff
X-Frame-Options: DENY
X-Konnectd-Version: 0.0.0
X-Xss-Protection: 1; mode=block

log logs in the ocis console

with LDAP I get redirected after the kopano page, but the request to https://localhost:9200/ocs/v1.php/cloud/capabilities?format=json get a HTTP 500 response and I end up on a login error page.

ocis log output:

2020-07-23 14:23:59  file=grpc/grpc.go:373 level=error panic recovered: runtime error: invalid memory address or nil pointer dereference
2020-07-23 14:23:59  file=grpc/grpc.go:374 level=error goroutine 110 [running]:
runtime/debug.Stack(0xc00000e4e0, 0xc001c6fa02, 0xc001c6fa20)
	/usr/local/go/src/runtime/debug/stack.go:24 +0x9d
github.com/micro/go-micro/v2/server/grpc.(*grpcServer).processRequest.func1.1(0xc000e78b38)
	/home/artur/go/pkg/mod/github.com/micro/go-micro/v2@v2.8.0/server/grpc/grpc.go:374 +0x2cf
panic(0x2da2140, 0x4850f50)
	/usr/local/go/src/runtime/panic.go:679 +0x1b2
github.com/owncloud/ocis-accounts/pkg/service/v0.Service.ListAccounts(0xc001f809e0, 0x19, 0x364fa80, 0xc0012a52b0, 0xff, 0x0, 0x0, 0xc001270e00, 0x15, 0x1f4, ...)
	/home/artur/go/pkg/mod/github.com/owncloud/ocis-accounts@v0.1.2-0.20200721035523-7af05fb19171/pkg/service/v0/accounts.go:236 +0x673
github.com/owncloud/ocis-accounts/pkg/proto/v0.(*accountsServiceHandler).ListAccounts(0xc002550b60, 0x368d300, 0xc001ca7770, 0xc002675f80, 0xc00093ae10, 0x7fbdd7557460, 0x0)
	/home/artur/go/pkg/mod/github.com/owncloud/ocis-accounts@v0.1.2-0.20200721035523-7af05fb19171/pkg/proto/v0/accounts.pb.micro.go:229 +0x5b
reflect.Value.call(0xc00243f100, 0xc00255e7f8, 0x13, 0x315f452, 0x4, 0xc000e78a98, 0x4, 0x4, 0x16, 0x2ffd400, ...)
	/usr/local/go/src/reflect/value.go:460 +0x5f6
reflect.Value.Call(0xc00243f100, 0xc00255e7f8, 0x13, 0xc000f16a98, 0x4, 0x4, 0x203000, 0x203000, 0xc000f16a50)
	/usr/local/go/src/reflect/value.go:321 +0xb4
github.com/micro/go-micro/v2/server/grpc.(*grpcServer).processRequest.func1(0x368d300, 0xc001ca7770, 0x36ae4c0, 0xc0000d6d00, 0x2fa85e0, 0xc00093ae10, 0x0, 0x0)
	/home/artur/go/pkg/mod/github.com/micro/go-micro/v2@v2.8.0/server/grpc/grpc.go:379 +0x303
github.com/micro/go-micro/v2/util/wrapper.AuthHandler.func1.1(0x368d300, 0xc001ca7770, 0x36ae4c0, 0xc0000d6d00, 0x2fa85e0, 0xc00093ae10, 0xc001ca7770, 0xc000426fc0)
	/home/artur/go/pkg/mod/github.com/micro/go-micro/v2@v2.8.0/util/wrapper/wrapper.go:239 +0x444
github.com/micro/go-micro/v2/util/wrapper.TraceHandler.func1.1(0x368d300, 0xc001ca7650, 0x36ae4c0, 0xc0000d6d00, 0x2fa85e0, 0xc00093ae10, 0x0, 0x0)
	/home/artur/go/pkg/mod/github.com/micro/go-micro/v2@v2.8.0/util/wrapper/wrapper.go:120 +0x1c6
github.com/micro/go-micro/v2/util/wrapper.HandlerStats.func1.1(0x368d300, 0xc001ca7650, 0x36ae4c0, 0xc0000d6d00, 0x2fa85e0, 0xc00093ae10, 0x0, 0x368d300)
	/home/artur/go/pkg/mod/github.com/micro/go-micro/v2@v2.8.0/util/wrapper/wrapper.go:65 +0x83
github.com/micro/go-plugins/wrapper/trace/opencensus/v2.NewHandlerWrapper.func1.1(0x368d300, 0xc001ca7650, 0x36ae4c0, 0xc0000d6d00, 0x2fa85e0, 0xc00093ae10, 0x0, 0x0)
	/home/artur/go/pkg/mod/github.com/micro/go-plugins/wrapper/trace/opencensus/v2@v2.0.1/opencensus.go:129 +0x419
github.com/owncloud/ocis-pkg/v2/wrapper/prometheus.NewHandlerWrapper.func1.1(0x368d300, 0xc001ca73e0, 0x36ae4c0, 0xc0000d6d00, 0x2fa85e0, 0xc00093ae10, 0x0, 0x0)
	/home/artur/go/pkg/mod/github.com/owncloud/ocis-pkg/v2@v2.2.2-0.20200602070144-cd0620668170/wrapper/prometheus/prometheus.go:77 +0x206
github.com/micro/go-micro/v2/util/wrapper.AuthHandler.func1.1(0x368d300, 0xc001ca7320, 0x36ae4c0, 0xc0000d6d00, 0x2fa85e0, 0xc00093ae10, 0xc001ca7320, 0xc000426f50)
	/home/artur/go/pkg/mod/github.com/micro/go-micro/v2@v2.8.0/util/wrapper/wrapper.go:239 +0x444
github.com/micro/go-micro/v2/util/wrapper.TraceHandler.func1.1(0x368d240, 0xc001d05280, 0x36ae4c0, 0xc0000d6d00, 0x2fa85e0, 0xc00093ae10, 0x16, 0x2fa85e0)
	/home/artur/go/pkg/mod/github.com/micro/go-micro/v2@v2.8.0/util/wrapper/wrapper.go:120 +0x1c6
github.com/micro/go-micro/v2/util/wrapper.HandlerStats.func1.1(0x368d240, 0xc001d05280, 0x36ae4c0, 0xc0000d6d00, 0x2fa85e0, 0xc00093ae10, 0x1c, 0x0)
	/home/artur/go/pkg/mod/github.com/micro/go-micro/v2@v2.8.0/util/wrapper/wrapper.go:65 +0x83
github.com/micro/go-micro/v2/server/grpc.(*grpcServer).processRequest(0xc00026b380, 0x369e500, 0xc00017c6c0, 0xc002657a00, 0xc001fdfc20, 0xc002694fe0, 0x16, 0x368d240, 0xc001d05280, 0xc000268000, ...)
	/home/artur/go/pkg/mod/github.com/micro/go-micro/v2@v2.8.0/server/grpc/grpc.go:396 +0x7ee
github.com/micro/go-micro/v2/server/grpc.(*grpcServer).handler(0xc00026b380, 0x0, 0x0, 0x369e500, 0xc00017c6c0, 0x0, 0x0)
	/home/artur/go/pkg/mod/github.com/micro/go-micro/v2@v2.8.0/server/grpc/grpc.go:315 +0x77f
google.golang.org/grpc.(*Server).processStreamingRPC(0xc001f8db00, 0x36ae640, 0xc001692a80, 0xc000171e00, 0x0, 0xc002662d00, 0x0, 0x0, 0x0)
	/home/artur/go/pkg/mod/google.golang.org/grpc@v1.26.0/server.go:1237 +0xb44
google.golang.org/grpc.(*Server).handleStream(0xc001f8db00, 0x36ae640, 0xc001692a80, 0xc000171e00, 0x0)
	/home/artur/go/pkg/mod/google.golang.org/grpc@v1.26.0/server.go:1323 +0xc0c
google.golang.org/grpc.(*Server).serveStreams.func1.1(0xc001d5bca0, 0xc001f8db00, 0x36ae640, 0xc001692a80, 0xc000171e00)
	/home/artur/go/pkg/mod/google.golang.org/grpc@v1.26.0/server.go:722 +0xbb
created by google.golang.org/grpc.(*Server).serveStreams.func1
	/home/artur/go/pkg/mod/google.golang.org/grpc@v1.26.0/server.go:720 +0xa1

2020-07-23 14:23:59  file=grpc/grpc.go:373 level=error panic recovered: runtime error: invalid memory address or nil pointer dereference
2020-07-23 14:23:59  file=grpc/grpc.go:374 level=error goroutine 130 [running]:
runtime/debug.Stack(0xc00000e4e0, 0xc001e08802, 0xc001e08800)
	/usr/local/go/src/runtime/debug/stack.go:24 +0x9d
github.com/micro/go-micro/v2/server/grpc.(*grpcServer).processRequest.func1.1(0xc000e78b38)
	/home/artur/go/pkg/mod/github.com/micro/go-micro/v2@v2.8.0/server/grpc/grpc.go:374 +0x2cf
panic(0x2da2140, 0x4850f50)
	/usr/local/go/src/runtime/panic.go:679 +0x1b2
github.com/owncloud/ocis-accounts/pkg/service/v0.Service.ListAccounts(0xc001f809e0, 0x19, 0x364fa80, 0xc0012a52b0, 0xff, 0x0, 0x0, 0xc001270e00, 0x15, 0x1f4, ...)
	/home/artur/go/pkg/mod/github.com/owncloud/ocis-accounts@v0.1.2-0.20200721035523-7af05fb19171/pkg/service/v0/accounts.go:236 +0x673
github.com/owncloud/ocis-accounts/pkg/proto/v0.(*accountsServiceHandler).ListAccounts(0xc002550b60, 0x368d300, 0xc00260f140, 0xc0003b12c0, 0xc00169eb90, 0x7fbdd7557460, 0x0)
	/home/artur/go/pkg/mod/github.com/owncloud/ocis-accounts@v0.1.2-0.20200721035523-7af05fb19171/pkg/proto/v0/accounts.pb.micro.go:229 +0x5b
reflect.Value.call(0xc00243f100, 0xc00255e7f8, 0x13, 0x315f452, 0x4, 0xc000f16a98, 0x4, 0x4, 0x16, 0x2ffd400, ...)
	/usr/local/go/src/reflect/value.go:460 +0x5f6
reflect.Value.Call(0xc00243f100, 0xc00255e7f8, 0x13, 0xc000f16a98, 0x4, 0x4, 0x203000, 0x203000, 0xc000f16a50)
	/usr/local/go/src/reflect/value.go:321 +0xb4
github.com/micro/go-micro/v2/server/grpc.(*grpcServer).processRequest.func1(0x368d300, 0xc00260f140, 0x36ae4c0, 0xc001f84780, 0x2fa85e0, 0xc00169eb90, 0x0, 0x0)
	/home/artur/go/pkg/mod/github.com/micro/go-micro/v2@v2.8.0/server/grpc/grpc.go:379 +0x303
github.com/micro/go-micro/v2/util/wrapper.AuthHandler.func1.1(0x368d300, 0xc00260f140, 0x36ae4c0, 0xc001f84780, 0x2fa85e0, 0xc00169eb90, 0xc00260f140, 0xc000427650)
	/home/artur/go/pkg/mod/github.com/micro/go-micro/v2@v2.8.0/util/wrapper/wrapper.go:239 +0x444
github.com/micro/go-micro/v2/util/wrapper.TraceHandler.func1.1(0x368d300, 0xc00260f020, 0x36ae4c0, 0xc001f84780, 0x2fa85e0, 0xc00169eb90, 0x0, 0x0)
	/home/artur/go/pkg/mod/github.com/micro/go-micro/v2@v2.8.0/util/wrapper/wrapper.go:120 +0x1c6
github.com/micro/go-micro/v2/util/wrapper.HandlerStats.func1.1(0x368d300, 0xc00260f020, 0x36ae4c0, 0xc001f84780, 0x2fa85e0, 0xc00169eb90, 0x0, 0x368d300)
	/home/artur/go/pkg/mod/github.com/micro/go-micro/v2@v2.8.0/util/wrapper/wrapper.go:65 +0x83
github.com/micro/go-plugins/wrapper/trace/opencensus/v2.NewHandlerWrapper.func1.1(0x368d300, 0xc00260f020, 0x36ae4c0, 0xc001f84780, 0x2fa85e0, 0xc00169eb90, 0x0, 0x0)
	/home/artur/go/pkg/mod/github.com/micro/go-plugins/wrapper/trace/opencensus/v2@v2.0.1/opencensus.go:129 +0x419
github.com/owncloud/ocis-pkg/v2/wrapper/prometheus.NewHandlerWrapper.func1.1(0x368d300, 0xc00260ede0, 0x36ae4c0, 0xc001f84780, 0x2fa85e0, 0xc00169eb90, 0x0, 0x0)
	/home/artur/go/pkg/mod/github.com/owncloud/ocis-pkg/v2@v2.2.2-0.20200602070144-cd0620668170/wrapper/prometheus/prometheus.go:77 +0x206
github.com/micro/go-micro/v2/util/wrapper.AuthHandler.func1.1(0x368d300, 0xc00260ed20, 0x36ae4c0, 0xc001f84780, 0x2fa85e0, 0xc00169eb90, 0xc00260ed20, 0xc0004275e0)
	/home/artur/go/pkg/mod/github.com/micro/go-micro/v2@v2.8.0/util/wrapper/wrapper.go:239 +0x444
github.com/micro/go-micro/v2/util/wrapper.TraceHandler.func1.1(0x368d240, 0xc001d05880, 0x36ae4c0, 0xc001f84780, 0x2fa85e0, 0xc00169eb90, 0x16, 0x2fa85e0)
	/home/artur/go/pkg/mod/github.com/micro/go-micro/v2@v2.8.0/util/wrapper/wrapper.go:120 +0x1c6
github.com/micro/go-micro/v2/util/wrapper.HandlerStats.func1.1(0x368d240, 0xc001d05880, 0x36ae4c0, 0xc001f84780, 0x2fa85e0, 0xc00169eb90, 0x1c, 0x0)
	/home/artur/go/pkg/mod/github.com/micro/go-micro/v2@v2.8.0/util/wrapper/wrapper.go:65 +0x83
github.com/micro/go-micro/v2/server/grpc.(*grpcServer).processRequest(0xc00026b380, 0x369e500, 0xc00017c9c0, 0xc002657a00, 0xc001fdfc20, 0xc0026955e0, 0x16, 0x368d240, 0xc001d05880, 0xc000268000, ...)
	/home/artur/go/pkg/mod/github.com/micro/go-micro/v2@v2.8.0/server/grpc/grpc.go:396 +0x7ee
github.com/micro/go-micro/v2/server/grpc.(*grpcServer).handler(0xc00026b380, 0x0, 0x0, 0x369e500, 0xc00017c9c0, 0x0, 0x0)
	/home/artur/go/pkg/mod/github.com/micro/go-micro/v2@v2.8.0/server/grpc/grpc.go:315 +0x77f
google.golang.org/grpc.(*Server).processStreamingRPC(0xc001f8db00, 0x36ae640, 0xc001693080, 0xc000171f00, 0x0, 0xc002662d00, 0x0, 0x0, 0x0)
	/home/artur/go/pkg/mod/google.golang.org/grpc@v1.26.0/server.go:1237 +0xb44
google.golang.org/grpc.(*Server).handleStream(0xc001f8db00, 0x36ae640, 0xc001693080, 0xc000171f00, 0x0)
	/home/artur/go/pkg/mod/google.golang.org/grpc@v1.26.0/server.go:1323 +0xc0c
google.golang.org/grpc.(*Server).serveStreams.func1.1(0xc0012adf30, 0xc001f8db00, 0x36ae640, 0xc001693080, 0xc000171f00)
	/home/artur/go/pkg/mod/google.golang.org/grpc@v1.26.0/server.go:722 +0xbb
created by google.golang.org/grpc.(*Server).serveStreams.func1
	/home/artur/go/pkg/mod/google.golang.org/grpc@v1.26.0/server.go:720 +0xa1

2020-07-23T14:23:59+05:45 ERR Error fetching from accounts-service error="{\"id\":\"go.micro.server\",\"code\":500,\"detail\":\"panic recovered: runtime error: invalid memory address or nil pointer dereference\",\"status\":\"Internal Server Error\"}" query="mail eq 'user0@example.org'" service=proxy

CC @butonic

IljaN · 2020-07-23T11:26:45Z

We probably should execute go mod tidy at the end

butonic · 2020-07-27T13:15:28Z

2020-07-27T12:14:44Z ERR could not initialize oidc provider error="oidc: issuer did not match the issuer returned by provider, expected \"https://localhost:9200\" got \"https://ocis-server:9200\"" service=proxy

individual-it · 2020-07-28T06:02:52Z

update docs about how to run tests (new settings) https://owncloud.github.io/ocis/testing/#run-ocis-with-that-ldap-server

refs · 2020-07-28T11:06:45Z

While digging into the tests, a failing scenario has different expectations on uid_owner:

butonic · 2020-07-28T11:49:22Z

The problem is that we are provisioning test users using ldap. thas leads to a disconnect beween usernames (in ldap) and the uuid that is generated by the accounts service. As a result, the api tests (which are using basic auth) will resolve the login to the uid attribute in ldap, e.g. user0 but the acceptance tests using konnectd will resolve the oidc claims to the account id which is generated when first provisioning user0.

We have several short term options:

make the testsuite use the accounts grpc api to provision users
implement the ocs users endpoint of the provisioning API (userid = accountid, a new username property that can be set independently from the userid in ocis. for oc10 it can be the same as the userid)
- but to provision users we would have to call the accounts api, using a go micro client ... if ocs/cloud/users would live in ocis-ocs
- we can use the proxy to redirect requests there

Long term solution: implment an ocis-accounts-ldap service that is persists users in ldap directly.

I would vote for implementing the ocs provisioning api, as we need that anyway.

Even with a provisioning API implementation the testsuite might have to wipe a users storage manually, because currently we do not deporvision a users files, only the account.

kulmann · 2020-07-28T19:09:18Z

@individual-it since the most recent commit to this PR (21db7ed), we now have the important bits of the user provisioning API in ocis-ocs. Could you please check, if you can make use of this for provisioning users in tests? Afaik you already do this for oc10. Maybe it is a quick win to do the same in ocis now. Please check if the provided API is sufficient for your needs - and if not, what else you need.
ocis-proxy also routes /ocs/v[1,2].php/cloud/users to ocis-ocs by default now. That is already in this PR as well. If you have a manual proxy config, you'll need to adapt it. See owncloud/ocis-proxy#80 for the default route.

butonic · 2020-07-28T19:16:59Z

@kulmann also needs owncloud/ocis-accounts#70 but the web ui tests fail there

butonic · 2020-07-28T19:35:14Z

@individual-it btw the provisioning endpoint for users in ocis allows you to set the displayname, email and username in the initial POST. no need for subsequent edit calls ...

individual-it · 2020-07-29T04:08:38Z

@kulmann @butonic ~~what user should be used to drive the provisioning API? In oc10 there is an "admin" user, what is the equivalent in ocis now?~~ - no auth required

issues with the new provisioning API

when now simply running bin/ocis server and no special settings I cannot login as einstein to phoenix. The login hangs in the Redirecting screen
I guess its because groups are not supported and the requests to /groups returns

<?xml version="1.0" encoding="UTF-8"?>
<ocs><meta><status>error</status><statuscode>999</statuscode><message>please check the syntax. API specifications are here: http://www.freedesktop.org/wiki/Specifications/open-collaboration-services</message></meta></ocs>

there is no way to delete users. We might get away with it by deleting the user folder and the delete and recreate user will be a NOP
mandatory fields seem to be userid username password and email , in the provisioning API of oC10 there is no fields username and email is not a mandatory field

individual-it · 2020-07-30T04:40:56Z

current issues:

user json file gets randomly corrupted:

2020-07-30T09:32:44+05:45 WRN http end="30/Jul/2020:09:32:44 +0545" host=127.0.0.1 method=POST pkg=rhttp proto=HTTP/1.1 service=reva size=141 start="30/Jul/2020:09:32:44 +0545" status=404 time_ns=45967894 traceid=6dab709d9394b4be604b001582897146 uri=/ocs/v2.php/privatedata/setattribute/testing/test url=/ocs/v2.php/privatedata/setattribute/testing/test
2020-07-30T09:32:44+05:45 ERR could not load account error="{\"id\":\"com.owncloud.api.accounts\",\"code\":500,\"detail\":\"could not unmarshal account: invalid character 'A' after top-level value\",\"status\":\"Internal Server Error\"}" account=another-admin service=accounts
2020-07-30T09:32:44+05:45 ERR could not load account error="{\"id\":\"com.owncloud.api.accounts\",\"code\":500,\"detail\":\"could not unmarshal account: invalid character 'A' after top-level value\",\"status\":\"Internal Server Error\"}" account=another-admin service=accounts
2020-07-30T09:32:44+05:45 ERR could not index new account error="{\"id\":\"com.owncloud.api.accounts\",\"code\":500,\"detail\":\"could not unmarshal account: invalid character 'A' after top-level value\",\"status\":\"Internal Server Error\"}" id=another-admin path=/var/tmp/ocis-accounts/accounts/another-admin service=accounts
2020-07-30T09:32:44+05:45 ERR could not index new account error="{\"id\":\"com.owncloud.api.accounts\",\"code\":500,\"detail\":\"could not unmarshal account: invalid character 'A' after top-level value\",\"status\":\"Internal Server Error\"}" id=another-admin path=/var/tmp/ocis-accounts/accounts/another-admin service=accounts
2020-07-30T09:32:44+05:45 ERR could not load account error="{\"id\":\"com.owncloud.api.accounts\",\"code\":500,\"detail\":\"could not unmarshal account: invalid character 'A' after top-level value\",\"status\":\"Internal Server Error\"}" id=another-admin service=accounts
2020-07-30T09:32:44+05:45 ERR could not load account error="{\"id\":\"com.owncloud.api.accounts\",\"code\":500,\"detail\":\"could not unmarshal account: invalid character 'A' after top-level value\",\"status\":\"Internal Server Error\"}" id=another-admin service=accounts
2020-07-30T09:32:44+05:45 ERR could not edit user error="{\"id\":\"com.owncloud.api.accounts\",\"code\":500,\"detail\":\"could not unmarshal account: invalid character 'A' after top-level value\",\"status\":\"Internal Server Error\"}" service=ocs userid=another-admin
2020-07-30T09:32:44+05:45 ERR could not edit user error="{\"id\":\"com.owncloud.api.accounts\",\"code\":500,\"detail\":\"could not unmarshal account: invalid character 'A' after top-level value\",\"status\":\"Internal Server Error\"}" service=ocs userid=another-admin
2020-07-30T09:32:44+05:45 ERR could not load account error="{\"id\":\"com.owncloud.api.accounts\",\"code\":500,\"detail\":\"could not unmarshal account: invalid character 'A' after top-level value\",\"status\":\"Internal Server Error\"}" id=another-admin service=accounts
2020-07-30T09:32:44+05:45 ERR could not load account error="{\"id\":\"com.owncloud.api.accounts\",\"code\":500,\"detail\":\"could not unmarshal account: invalid character 'A' after top-level value\",\"status\":\"Internal Server Error\"}" id=another-admin service=accounts
2020-07-30T09:32:44+05:45 ERR could not get user error="{\"id\":\"com.owncloud.api.accounts\",\"code\":500,\"detail\":\"could not unmarshal account: invalid character 'A' after top-level value\",\"status\":\"Internal Server Error\"}" service=ocs userid=another-admin

individual-it · 2020-07-30T10:10:59Z

basic auth is not checked the second time, when the username is capital case:
create a user: curl -k -X POST https://localhost:9200/ocs/v1.php/cloud/users -d userid="Artur" -d password="Artur" -d email="Artur@a.de" -d username="Artur"
make a request with the correct password: curl -u Artur:Artur -k -X PROPFIND https://localhost:9200/remote.php/webdav
make a request with the wrong password: curl -u Artur:invalid -k -X PROPFIND https://localhost:9200/remote.php/webdav

both requests response with content if first the correct password was given AND the userid begins with a capital case 🙀

butonic · 2020-07-30T10:32:23Z

@individual-it can you post instructions how to run the testsuite with the user provisioning api here so we can continue when you need to leave. We found a problem in reva: cs3org/reva#1033 that requires some coding to properly look up the userid ...

individual-it · 2020-07-30T10:53:22Z

@butonic

delete all ocis & reva files rm -r /var/tmp/ocis-*; rm -r /var/tmp/reva/
start a redis server docker run --rm -d -p 6379:6379 -e REDIS_DATABASES=1 --name redis webhippie/redis:latest
start ocis bin/ocis server
on owncloud/core checkout testFixOCISPR409 branch
clone testing app into apps/testing
from core folder run tests: make test-acceptance-api TEST_SERVER_URL=https://localhost:9200 TEST_OCIS=true OCIS_REVA_DATA_ROOT=/var/tmp/reva/ SKELETON_DIR=apps/testing/data/apiSkeleton BEHAT_FILTER_TAGS='~@skipOnOcis&&~@skipOnOcis-OC-Storage' use BEHAT_FEATURE to run a single file or scenario

PVince81 · 2020-08-17T14:24:38Z

PR for disabling randomly failing Phoenix test owncloud/web#3955
to be addressed later in https://github.com/owncloud/ocis-reva/issues/442

PVince81 · 2020-08-17T14:27:09Z

update drone phoenix commit after merging [Tests-only] Disable test for partial deletion web#3955

- ocis-ocs v0.2.0 - ocis-pkg/v2 v2.3.0 - ocis-proxy v0.6.0 - ocis-reva v0.12.0 - ocis-settings v0.1.0 - ocis-store v0.1.1 - ocis-thumbnails v0.3.0

kulmann · 2020-08-17T20:36:17Z

Updated ocis-phoenix to 0.11.0 (includes phoenix 0.14.0).

phil-davis · 2020-08-18T05:42:48Z

tests/acceptance/features/apiOcisSpecific/apiWebdavPreviews-previews.feature

-@api @issue-ocis-187
-Feature: previews of files downloaded through the webdav API


Why did these get deleted?
I don't see where previews was fixed in core - expected-failures.txt has a whole list of core scenarios apiWebdavPreviews/previews.feature:* that are still expected failures.

In a separate PR I can try what happens if these "bug demo scenarios" are put back.

phil-davis · 2020-08-18T05:45:02Z

I pushed 2 commits to tidy up some doc and comments in expected-failures.txt. None of that should break anything. CI is currently running.

Are we going to squash the 84 commits before merging?

PVince81 · 2020-08-18T07:15:43Z

Let's not squash these, keep them as a tribute and reminder of our struggles.

PVince81 · 2020-08-18T07:16:16Z

Any objections to merging this PR now ?

I think we're already far enough down the road that it doesn't make sense to hold this any more.

If we find any regressions in EOS we'll fix these separately.

PVince81

👍

Merge: aa4c13f bce5e63 Author: Vincent Petry <pvince81@owncloud.com> Date: Tue Aug 18 09:44:24 2020 +0200 Merge pull request #409 from owncloud/update-deps-2020-07-22 Update deps 2020 07 22

[Tests-Only] Bump commit id for oC10APIAcceptanceTests

dpakach mentioned this pull request Jul 23, 2020

Add settings tests owncloud/web#3491

Closed

kulmann force-pushed the update-deps-2020-07-22 branch from 87d945c to 5f97bc1 Compare July 23, 2020 14:51

kulmann mentioned this pull request Jul 24, 2020

Reminder: co-dependencies / merge preparation #380

Closed

butonic force-pushed the update-deps-2020-07-22 branch from b9d6dac to a2a6e28 Compare July 24, 2020 15:26

butonic added the enhancement label Jul 27, 2020

butonic assigned butonic, kulmann and refs Jul 27, 2020

butonic force-pushed the update-deps-2020-07-22 branch 2 times, most recently from 7a3cb9b to 0b3aa07 Compare July 27, 2020 14:23

kulmann force-pushed the update-deps-2020-07-22 branch from 9a1ce4b to d4f2c93 Compare July 27, 2020 20:19

individual-it mentioned this pull request Jul 28, 2020

[tests-only] Fix tests for ocis with proxy owncloud/core#37742

Merged

11 tasks

individual-it mentioned this pull request Jul 29, 2020

[tests-only] use usersHaveBeenCreated & delete UserHelper::createUser owncloud/core#37749

Merged

11 tasks

Vincent Petry and others added 3 commits August 17, 2020 17:39

Update Phoenix commit for disabled deletion tests

29efcbb

Update modules to tagged versions

ebcc8c6

- ocis-ocs v0.2.0 - ocis-pkg/v2 v2.3.0 - ocis-proxy v0.6.0 - ocis-reva v0.12.0 - ocis-settings v0.1.0 - ocis-store v0.1.1 - ocis-thumbnails v0.3.0

Update ocis-phoenix to 0.11.0

ddf51d2

phil-davis mentioned this pull request Aug 18, 2020

[Tests-Only] Implement separate expected-failures files for OC and EOS storage owncloud/ocis-reva#444

Merged

phil-davis added 2 commits August 18, 2020 11:18

Fix some typos in docs/eos.md

829657e

Put back some comment text in expected-failures.txt

bce5e63

phil-davis reviewed Aug 18, 2020

View reviewed changes

phil-davis mentioned this pull request Aug 18, 2020

Put back local preview test scenarios #460

Merged

PVince81 approved these changes Aug 18, 2020

View reviewed changes

PVince81 merged commit 0a8c913 into master Aug 18, 2020

PVince81 deleted the update-deps-2020-07-22 branch August 18, 2020 07:45

ownclouders pushed a commit that referenced this pull request Aug 18, 2020

commit 0a8c913

8442593

Merge: aa4c13f bce5e63 Author: Vincent Petry <pvince81@owncloud.com> Date: Tue Aug 18 09:44:24 2020 +0200 Merge pull request #409 from owncloud/update-deps-2020-07-22 Update deps 2020 07 22

This was referenced Aug 19, 2020

upload issues under load owncloud/product#162

Closed

use newest ocis binary for tests owncloud/web#3962

Closed

This was referenced Aug 21, 2020

[tests-only] advance commit id of ocis & phoenix owncloud/ocis-accounts#90

Merged

fix documentation about running API/UI tests with OCIS owncloud/product#176

Closed

refs pushed a commit that referenced this pull request Sep 18, 2020

Merge pull request #409 from owncloud/bump-core-commit-20200728-2

a736161

[Tests-Only] Bump commit id for oC10APIAcceptanceTests

PVince81 mentioned this pull request Jan 18, 2021

Ability to specify user name in Webdav path despite UUID mode #1244

Closed

individual-it mentioned this pull request Jan 25, 2021

create HTTP tests #1419

Closed

PVince81 mentioned this pull request Jan 25, 2021

thumbnail service troubles with new ocis-accounts #1470

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update deps 2020 07 22 #409

Update deps 2020 07 22 #409

kulmann commented Jul 22, 2020 •

edited

Loading

update-docs bot commented Jul 22, 2020

kulmann commented Jul 23, 2020 •

edited

Loading

individual-it commented Jul 23, 2020

IljaN commented Jul 23, 2020

butonic commented Jul 27, 2020

individual-it commented Jul 28, 2020

refs commented Jul 28, 2020

butonic commented Jul 28, 2020 •

edited

Loading

kulmann commented Jul 28, 2020

butonic commented Jul 28, 2020

butonic commented Jul 28, 2020

individual-it commented Jul 29, 2020 •

edited

Loading

individual-it commented Jul 30, 2020 •

edited

Loading

individual-it commented Jul 30, 2020

butonic commented Jul 30, 2020

individual-it commented Jul 30, 2020 •

edited

Loading

PVince81 commented Aug 17, 2020

PVince81 commented Aug 17, 2020 •

edited

Loading

kulmann commented Aug 17, 2020 •

edited

Loading

phil-davis Aug 18, 2020

phil-davis commented Aug 18, 2020

PVince81 commented Aug 18, 2020

PVince81 commented Aug 18, 2020

PVince81 left a comment

		@api @issue-ocis-187
		Feature: previews of files downloaded through the webdav API

Update deps 2020 07 22 #409

Update deps 2020 07 22 #409

Conversation

kulmann commented Jul 22, 2020 • edited Loading

Disclaimer

Debugging failing tests

Technical debt / future tasks to schedule

update-docs bot commented Jul 22, 2020

kulmann commented Jul 23, 2020 • edited Loading

individual-it commented Jul 23, 2020

IljaN commented Jul 23, 2020

butonic commented Jul 27, 2020

individual-it commented Jul 28, 2020

refs commented Jul 28, 2020

butonic commented Jul 28, 2020 • edited Loading

kulmann commented Jul 28, 2020

butonic commented Jul 28, 2020

butonic commented Jul 28, 2020

individual-it commented Jul 29, 2020 • edited Loading

individual-it commented Jul 30, 2020 • edited Loading

individual-it commented Jul 30, 2020

butonic commented Jul 30, 2020

individual-it commented Jul 30, 2020 • edited Loading

PVince81 commented Aug 17, 2020

PVince81 commented Aug 17, 2020 • edited Loading

kulmann commented Aug 17, 2020 • edited Loading

phil-davis Aug 18, 2020

Choose a reason for hiding this comment

phil-davis commented Aug 18, 2020

PVince81 commented Aug 18, 2020

PVince81 commented Aug 18, 2020

PVince81 left a comment

Choose a reason for hiding this comment

kulmann commented Jul 22, 2020 •

edited

Loading

kulmann commented Jul 23, 2020 •

edited

Loading

butonic commented Jul 28, 2020 •

edited

Loading

individual-it commented Jul 29, 2020 •

edited

Loading

individual-it commented Jul 30, 2020 •

edited

Loading

individual-it commented Jul 30, 2020 •

edited

Loading

PVince81 commented Aug 17, 2020 •

edited

Loading

kulmann commented Aug 17, 2020 •

edited

Loading