Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of hideSearchBar option by using existing capability #6806

Closed
butonic opened this issue Apr 22, 2022 · 1 comment · Fixed by #6856
Closed

get rid of hideSearchBar option by using existing capability #6806

butonic opened this issue Apr 22, 2022 · 1 comment · Fixed by #6856

Comments

@butonic
Copy link
Member

butonic commented Apr 22, 2022

Currently web checks a dedicated option to disable the search bar, introduced wcith #3817

However, the capabilities do contain the list of reports that clients can fire against webdav.

For backend search (aka sdk search) the capabilities.dav.reports string array has to contain "search-files":

...
{
  "dav":{
    "chunking":"",
    "trashbin":"1.0",
    "reports": ["search-files"],
    "chunkingParallelUploadDisabled":false
  }
}
...

Web should rely on that dav.reports property in the capabilities instead of an option in the config.

Another report is a filter-files report which is used to filter files by favorites and tags ... but that is a different issue.

@kulmann
Copy link
Member

kulmann commented Apr 26, 2022

Agreed, capability should have precedence and the config.json option can be dropped immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants