Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Messages not shown in fullscreen apps #4335

Closed
VirtualEvan opened this issue Nov 18, 2020 · 3 comments
Closed

[Bug] Messages not shown in fullscreen apps #4335

VirtualEvan opened this issue Nov 18, 2020 · 3 comments
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@VirtualEvan
Copy link
Contributor

Steps to reproduce

  1. Define an app as full screen
    {
      name: 'draw-io-edit',
      path: '/edit/:filePath',
      components: {
        fullscreen: DrawIoEditor
      },
      meta: { hideHeadbar: true }
    }
  2. Use the showMessage function

The message is shown if the fullscreen property is changed to app and hideHeadbar is removed

{
  name: 'draw-io-edit',
  path: '/edit/:filePath',
  components: {
    app: DrawIoEditor
  }
}

Expected behaviour

The speified message should be shown

Actual behaviour

The message is not displayed

@pascalwengerter
Copy link
Contributor

Hey @VirtualEvan, is this issue still open after your PR has been merged? :)

@VirtualEvan
Copy link
Contributor Author

VirtualEvan commented Mar 16, 2021

Yes, this issue is something I found while working in the draw.io app, my PR did not address it

@pascalwengerter pascalwengerter added Web-Fastlane Type:Bug Something isn't working labels Jun 10, 2021
@kulmann kulmann added the Priority:p2-high Escalation, on top of current planning, release blocker label Dec 3, 2021
@kulmann
Copy link
Member

kulmann commented Mar 8, 2022

Apps are now always forced into an application layout which contains the message-bar component and handles the active messages. The fullscreen mode has been removed entirely in #6401 - closing this issue here as solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants