[full-ci] Enforce extensions to always display the ui-header #6401

fschade · 2022-02-09T14:12:01Z

Description

Prior this, extensions where able to decide if the ui should render the header or not,
this now is disabled to transport even more the feeling of having a portal.

Related Issue

Needed for Release 5.0.0 #6248

Motivation and Context

have more integrated applications

How Has This Been Tested?

existing unit and integration tests

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Code changes

diocas · 2022-02-09T15:03:48Z

@fschade looks good and works well. The only thing missing is setting border: 0 in the external apps' iframe (for chrome users).
(ping @pascalwengerter as well)

kulmann · 2022-02-09T15:41:31Z

While this is awesome, the public link resolve page for when you need to add a password doesn't look good anymore. I know, you told me so. Let me push a fix for that. 😄

kulmann

Let me put a block on this PR... I'll push fixes for the non-runtime pages that were previously fullscreen. I.e. private and public link resolver pages. We also need to disable e.g. the search bar on those resolver pages.

pascalwengerter

Should be fine (aside from the comments, doing a visual check now). Might also be worth to run it with [full-ci] to catch all the DOM changes that the acceptance tests may disagree with at once

packages/web-app-files/src/App.vue

packages/web-app-files/tests/unit/views/FilesDrop.spec.js

ownclouders · 2022-02-10T14:54:19Z

Results for oC10Basic2 https://drone.owncloud.com/owncloud/web/22654/13/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIPrivateLinks-accessingPrivateLinks_feature-L35.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

ownclouders · 2022-02-10T15:58:27Z

Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/22658/37/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

ownclouders · 2022-02-10T21:46:17Z

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/22668/15/1
The following scenarios passed on retry:

webUISharingAcceptSharesToRoot/acceptShares.feature:108

ownclouders · 2022-02-10T21:52:10Z

Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/22668/37/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

ownclouders · 2022-02-10T21:54:14Z

Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/22668/36/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicBasic-publicLinkEdit_feature-L130.png

webUISharingPublicBasic-publicLinkEdit_feature-L88.png

webUISharingPublicBasic-publicLinkPublicActions_feature-L25.png

ownclouders · 2022-02-10T21:55:17Z

Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/22668/68/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

ownclouders · 2022-02-10T21:56:32Z

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/22668/67/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicBasic-publicLinkEdit_feature-L130.png

webUISharingPublicBasic-publicLinkEdit_feature-L88.png

webUISharingPublicBasic-publicLinkPublicActions_feature-L25.png

ownclouders · 2022-02-11T10:02:00Z

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/22680/15/1
The following scenarios passed on retry:

webUISharingAcceptSharesToRoot/acceptShares.feature:108

ownclouders · 2022-02-11T10:04:57Z

Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/22680/37/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

ownclouders · 2022-02-11T10:06:51Z

Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/22680/68/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

ownclouders · 2022-02-11T10:10:22Z

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/22680/67/1
The following scenarios passed on retry:

webUISharingPublicBasic/publicLinkCreate.feature:190

sonarcloud · 2022-02-11T11:33:08Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

ownclouders · 2022-02-11T11:49:43Z

Results for oCISFiles4 https://drone.owncloud.com/owncloud/web/22687/58/1
The following scenarios passed on retry:

webUIRenameFolders/renameFolders.feature:142

fschade requested a review from kulmann February 9, 2022 14:12

fschade requested a review from pascalwengerter as a code owner February 9, 2022 14:12

fschade mentioned this pull request Feb 9, 2022

Release 5.0.0 #6248

Closed

25 tasks

pascalwengerter mentioned this pull request Feb 9, 2022

Design polishing II: the return of the shadows #6383

Closed

12 tasks

kulmann requested changes Feb 9, 2022

View reviewed changes

fschade and others added 3 commits February 10, 2022 11:53

enforce the ui to always display the header

b9bba53

Restyle public and private link resolver pages

3d49014

Fix sidebar width and overflows

872f755

kulmann force-pushed the enforce-extention-header branch from d0e1744 to a8d17b3 Compare February 10, 2022 13:55

kulmann approved these changes Feb 10, 2022

View reviewed changes

pascalwengerter approved these changes Feb 10, 2022

View reviewed changes

packages/web-app-files/src/App.vue Show resolved Hide resolved

packages/web-app-files/tests/unit/views/FilesDrop.spec.js Outdated Show resolved Hide resolved

Make linter happier

84b773c

kulmann force-pushed the enforce-extention-header branch from a8d17b3 to 84b773c Compare February 10, 2022 14:29

kulmann changed the title ~~Enforce extensions to always display the ui-header~~ [full-ci] Enforce extensions to always display the ui-header Feb 10, 2022

kulmann force-pushed the enforce-extention-header branch from 322d199 to 3000c96 Compare February 11, 2022 09:34

Fix link resolving in tests

078862e

kulmann force-pushed the enforce-extention-header branch from 3000c96 to 078862e Compare February 11, 2022 11:14

get rid of empty style tag

396ba0f

kulmann merged commit e09700e into master Feb 11, 2022

delete-merged-branch bot deleted the enforce-extention-header branch February 11, 2022 12:08

This was referenced Feb 11, 2022

Adding of new routes fails for CERNbox #6428

Closed

App compatibility for old named routes #6439

Merged

kulmann mentioned this pull request Mar 8, 2022

[Bug] Messages not shown in fullscreen apps #4335

Closed

pascalwengerter mentioned this pull request May 5, 2022

Branding when sidebar is not visible #3520

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[full-ci] Enforce extensions to always display the ui-header #6401

[full-ci] Enforce extensions to always display the ui-header #6401

fschade commented Feb 9, 2022 •

edited

Loading

diocas commented Feb 9, 2022 •

edited

Loading

kulmann commented Feb 9, 2022

kulmann left a comment

pascalwengerter left a comment

ownclouders commented Feb 10, 2022

webUIPrivateLinks-accessingPrivateLinks_feature-L35.png

ownclouders commented Feb 10, 2022

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

ownclouders commented Feb 10, 2022

ownclouders commented Feb 10, 2022

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

ownclouders commented Feb 10, 2022

webUISharingPublicBasic-publicLinkEdit_feature-L130.png

webUISharingPublicBasic-publicLinkEdit_feature-L88.png

webUISharingPublicBasic-publicLinkPublicActions_feature-L25.png

ownclouders commented Feb 10, 2022

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

ownclouders commented Feb 10, 2022

webUISharingPublicBasic-publicLinkEdit_feature-L130.png

webUISharingPublicBasic-publicLinkEdit_feature-L88.png

webUISharingPublicBasic-publicLinkPublicActions_feature-L25.png

ownclouders commented Feb 11, 2022

ownclouders commented Feb 11, 2022

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

ownclouders commented Feb 11, 2022

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

ownclouders commented Feb 11, 2022

sonarcloud bot commented Feb 11, 2022

ownclouders commented Feb 11, 2022

[full-ci] Enforce extensions to always display the ui-header #6401

[full-ci] Enforce extensions to always display the ui-header #6401

Conversation

fschade commented Feb 9, 2022 • edited Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

diocas commented Feb 9, 2022 • edited Loading

kulmann commented Feb 9, 2022

kulmann left a comment

Choose a reason for hiding this comment

pascalwengerter left a comment

Choose a reason for hiding this comment

ownclouders commented Feb 10, 2022

webUIPrivateLinks-accessingPrivateLinks_feature-L35.png

ownclouders commented Feb 10, 2022

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

ownclouders commented Feb 10, 2022

ownclouders commented Feb 10, 2022

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

ownclouders commented Feb 10, 2022

webUISharingPublicBasic-publicLinkEdit_feature-L130.png

webUISharingPublicBasic-publicLinkEdit_feature-L88.png

webUISharingPublicBasic-publicLinkPublicActions_feature-L25.png

ownclouders commented Feb 10, 2022

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

ownclouders commented Feb 10, 2022

webUISharingPublicBasic-publicLinkEdit_feature-L130.png

webUISharingPublicBasic-publicLinkEdit_feature-L88.png

webUISharingPublicBasic-publicLinkPublicActions_feature-L25.png

ownclouders commented Feb 11, 2022

ownclouders commented Feb 11, 2022

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

ownclouders commented Feb 11, 2022

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

ownclouders commented Feb 11, 2022

sonarcloud bot commented Feb 11, 2022

ownclouders commented Feb 11, 2022

fschade commented Feb 9, 2022 •

edited

Loading

diocas commented Feb 9, 2022 •

edited

Loading