Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload files list of current view after accepting a share via notification #4839

Closed
kulmann opened this issue Mar 23, 2021 · 0 comments · Fixed by #6942
Closed

Reload files list of current view after accepting a share via notification #4839

kulmann opened this issue Mar 23, 2021 · 0 comments · Fixed by #6942

Comments

@kulmann
Copy link
Contributor

kulmann commented Mar 23, 2021

We'll introduce a regression when #4627 gets merged:

Steps to reproduce

  1. login as alice
  2. share a file or folder with bob
  3. login as bob
  4. have a notification about the new share
  5. accept the share with the respective button within the notification

Expected behaviour

The file list of the current view (personal, shared with me, others are not relevant) updates and shows the accepted resource / reflects that the resource is now accepted

Actual behaviour

The view doesn't update

Server configuration

ownCloud version: [10.6,)

Thoughts about when to solve it

When we migrated to vue3 and typescript we can refactor the code for loading resources. That is very repetitive as of writing this issue and involves 3-4 steps in every view (fetching the resources, transforming it into a format that is understood by e.g. the oc-table-files component, loading previews, loading indicators). When we refactor that we should also think about how to utilize resource loading from components outside of the files app, or if it even makes sense to move parts of the code to the runtime, so that accepting notifications doesn't have to rely on code of an extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants