[full-ci] Reload file list after accepting a remote share

[JammingBen]

Description

We've fixed a bug where the file list would not reload after accepting a remote share.

Related Issue

• Fixes after accepting a remote share the files-list is not reloaded #1774
• Fixes "Shares" folder does not appear when using share_folder and accepting remote share via notification #4247
• Fixes Reload files list of current view after accepting a share via notification #4839

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

[ownclouders]

Results for oC10iPhoneNotifications https://drone.owncloud.com/owncloud/web/25654/48/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

[JammingBen]

I'm not sure about the best solution here. I've now implemented it to always reload the file list when accepting a federated share. If we only want to reload when necessary, it gets a bit more complicated:

• Are we currently in the directory where the federated file will be located?
• Is there a default share folder like Shares? Does this folder already exist or does it need to be created (see "Shares" folder does not appear when using share_folder and accepting remote share via notification #4247)?

Especially the latter would require some more logic. Logic, that shouldn't exist in the web runtime. Hence we would need to write something in the files app.

@kulmann Any opinions here?

[pascalwengerter]

In general LGTM, would like to hear @fschade & @kulmann 's opinions first though

[kulmann]

Nice improvement to use the event bus for this. 👍 Small nitpick regarding a state value comparison.

[kulmann]

• Is there a default share folder like Shares? Does this folder already exist or does it need to be created (see "Shares" folder does not appear when using share_folder and accepting remote share via notification #4247)?

Especially the latter would require some more logic. Logic, that shouldn't exist in the web runtime. Hence we would need to write something in the files app.

That should happen in the backend anyway. We don't create the default share_folder location in the frontend code. Or did I misread your comment?

[JammingBen]

That should happen in the backend anyway. We don't create the default share_folder location in the frontend code. Or did I misread your comment?

The backend creates it, yes, but the frontend would need to know that to accordingly reload the page. Anyway, I think we're fine by always reloading when accepting a share, no matter in which directory you're currently in.

[kulmann]

That should happen in the backend anyway. We don't create the default share_folder location in the frontend code. Or did I misread your comment?

The backend creates it, yes, but the frontend would need to know that to accordingly reload the page. Anyway, I think we're fine by always reloading when accepting a share, no matter in which directory you're currently in.

Yes, same opinion 😇 Fine this way for the time being.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

11.8% Coverage
0.0% Duplication