E2e tests. implement tests for searching

[ScharfViktor]

need to implement:

• search by personal space. [tests-only] Add e2e tests for searching #7583
• search by shares jail
• search by project space after is fixed
• cannot be implemented see Hide search bar in public link context #7849 search for public (public link) (after this issue is fixed Searching in public link takes you to the personal of the creator of the public link #7603)

cases:

• searching folder/subfolder, [tests-only] Add e2e tests for searching #7583
• files [tests-only] Add e2e tests for searching #7583
• name of project space. after search doesn't find the project space by name ocis#4506 is fixed
• different register. Should be case independent. (You have folder "FolDer" and should find it by "foldeR" ) [tests-only] Add e2e tests for searching #7583
• pending or declined share (API tests added, no need for e2e - for context E2e tests. implement tests for searching #7395 (comment))
• deleted files. (API tests added, no need for e2e - for context E2e tests. implement tests for searching #7395 (comment))
• hidden files [tests-only] Add e2e tests for searching #7583
• check limit- 5 and more checked in api tests

[SwikritiT]

@ScharfViktor for character limit of search length FRONTEND_SEARCH_MIN_LENGTH this variable only works while searching for share. Is this the expected behavior for now?
I couldn't use global search to search for the project spaces. Look at the given video

simplescreenrecorder-2022-09-02_16.56.36.mp4

Also, I found a weird behavior while searching for a folder and navigating to it through the displayed search list

1. As user Einstein create folders like folder, newfolder, new-folder
2. Now search for folder
3. Now click on folder and navigate to the folder through search list like so

simplescreenrecorder-2022-09-02_16.36.32.mp4

4. Now make Einstein the Space Admin and repeat the same process of searching and navigating to folder through search list

simplescreenrecorder-2022-09-02_16.53.35.mp4

Now Resource not found is shown and the upload and new buttons are disabled.

Seems like a bug

[ScharfViktor]

There is existing bug: #7391
we are waiting fixing from backend side

[ScharfViktor]

I tested it (works correct for project and personal space).try test again after merging owncloud/ocis#4485

[ScharfViktor]

search by project space name: please skip this step owncloud/ocis#4506

[SwikritiT]

@ScharfViktor I found a weird behavior

1. As user Einstein create the following folders

      folder       
      new-folder   
      FolDer       
      folderPublic 
      test         

2. Now from the global search for folder, I get the following result, the test is also included in the search list while it shouldn't be
   

3. Weirdly I can only reproduce it with a keyword test.

4. In this I created more folders named one, two, three and when I search for folder , test is still displayed but not others
   

The test also fails here for the same reason https://drone.owncloud.com/owncloud/web/28072/12/13 passes in oc10 though

[ScharfViktor]

Yes, I can confirm it.
the first search gives me extra "foo" and "test" folders. Strange, but I don't see request with limit 5

if I click "search all files". It works correct

after that search work correct. If I try to search again

[SwikritiT]

yes weird, after I search in all files the issue is not reproducible at all

[SwikritiT]

yes weird, after I search in all files the issue is not reproducible at all

reproducible after reload, here it gives me all the folders created

[SwikritiT]

I created an issue here owncloud/ocis#4517

[SwikritiT]

@ScharfViktor as for declined and pending share, it is not displayed in the search list, I'm guessing that it's expected behavior.
Also, searching resources in trashbin doesn't give any result both in oc10 and ocis, is this also expected?

[SwikritiT]

created an issue for public link searching #7603

[ScharfViktor]

@ScharfViktor as for declined and pending share, it is not displayed in the search list, I'm guessing that it's expected behavior. Also, searching resources in trashbin doesn't give any result both in oc10 and ocis, is this also expected?

I think it it normal behaviors
I create api tests for searching declined and pending share and deleted files. let don't check it in e2e?

[SwikritiT]

@ScharfViktor as for declined and pending share, it is not displayed in the search list, I'm guessing that it's expected behavior. Also, searching resources in trashbin doesn't give any result both in oc10 and ocis, is this also expected?

I think it it normal behaviors I create api tests for searching declined and pending share and deleted files. let don't check it in e2e?

okay

[SwikritiT]

@ScharfViktor for shares jail is it enough with what is done in PR #7583 or do we need to add more and for check limit- 5 or more do you mean character limit by this? I can't find a way to set character limit for global search in ocis, I think we can do that in oc10 through occ command but I need to check first. Do you have any idea if it's possible in ocis or will it ever be?

[ScharfViktor]

I think it's enough for e2e tests. We have api tests with limit checking

[SwikritiT]

Okay I'll continue on adding steps for project space and public link after the related issues are fixed

[SwikritiT]

@ScharfViktor #7603 this issue has been fixed by #7849 which hides the search bar in the public link. So what do we do about the search for public (public link) ?

[ScharfViktor]

@ScharfViktor #7603 this issue has been fixed by #7849 which hides the search bar in the public link. So what do we do about the search for public (public link) ?

I think we should remove this case from issue as cannot be implemented. We can probably close the problem because space search by name will not be fixed in the near future.