Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScrollToResource function not working as expected #7601

Closed
Tracked by #9278
elizavetaRa opened this issue Sep 7, 2022 · 4 comments · Fixed by #9145
Closed
Tracked by #9278

ScrollToResource function not working as expected #7601

elizavetaRa opened this issue Sep 7, 2022 · 4 comments · Fixed by #9145

Comments

@elizavetaRa
Copy link
Member

Steps to reproduce

1a. By selected resource scroll up outside of the view with this resource and press key "down"
1b. By selected resource scroll down outside of the view with this resource and press key "up"

Expected behaviour

The called scrollToResource function shows the resource in the middle of the view

Actual behaviour

By 1a the resource is shown in the last row of the visible list. By 1b nothing happens

@tbsbdr
Copy link

tbsbdr commented Jun 29, 2023

@elizavetaRa I'd expect it work like this - are we on the same page?

screenshot_001308-converted.mp4

@elizavetaRa
Copy link
Member Author

So, you would change the selected resource on key up/down to previous/next, yes, that sounds logically to me.
What would happen by multiple selection? Deselect all selected and jump to the next after last?

If I scroll outside the view with the selection, I'd expect to scroll to the selection on key up/down still. Maybe not put the selection to the middle as I initially proposed.

(example how it scrolles to the view with selection on key up)
example

@tbsbdr
Copy link

tbsbdr commented Jul 10, 2023

What would happen by multiple selection? Deselect all selected and jump to the next after last?

👍 Yes

If I scroll outside the view with the selection, I'd expect to scroll to the selection on key up/down still. Maybe not put the selection to the middle as I initially proposed.

👍 Yes

@tbsbdr tbsbdr added this to the CERN Web Merge milestone Jul 10, 2023
@tbsbdr
Copy link

tbsbdr commented Jul 12, 2023

should be fixed via #9145

pascalwengerter added a commit to pascalwengerter/web that referenced this issue Jul 24, 2023
JammingBen pushed a commit that referenced this issue Jul 25, 2023
* Fix #7600 && #7601

* Fix useFileActionsCreateNewFolder.spec.ts

* Fix unit tests

---------

Co-authored-by: Dominik Schmidt <dev@dominik-schmidt.de>
saw-jan pushed a commit that referenced this issue Jul 27, 2023
* Fix #7600 && #7601

* Fix useFileActionsCreateNewFolder.spec.ts

* Fix unit tests

---------

Co-authored-by: Dominik Schmidt <dev@dominik-schmidt.de>
AlexAndBear pushed a commit that referenced this issue Aug 15, 2023
* Fix #7600 && #7601

* Fix useFileActionsCreateNewFolder.spec.ts

* Fix unit tests

---------

Co-authored-by: Dominik Schmidt <dev@dominik-schmidt.de>
AlexAndBear pushed a commit that referenced this issue Dec 13, 2023
* Fix #7600 && #7601

* Fix useFileActionsCreateNewFolder.spec.ts

* Fix unit tests

---------

Co-authored-by: Dominik Schmidt <dev@dominik-schmidt.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants