Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch Actions: Raw Button Has No Hover-State #9352

Closed
tbsbdr opened this issue Jul 5, 2023 · 9 comments · Fixed by #9346
Closed

Batch Actions: Raw Button Has No Hover-State #9352

tbsbdr opened this issue Jul 5, 2023 · 9 comments · Fixed by #9346
Assignees
Labels
Priority:p4-low Low priority Topic:good-first-issue beginner friendly task Type:Bug Something isn't working

Comments

@tbsbdr
Copy link

tbsbdr commented Jul 5, 2023

Steps to reproduce

  1. Hover on Batch Actions
  2. Raw Button Has No Hover-State
    screenshot_001341

Expected behaviour

  • Raw button should have hover (same as on view-options Icon: --oc-color-background-hover)
  • --oc-color-background-hover should have the color of --oc-color-background-highlight

screenshot_001349

Actual behaviour

  • Raw Button Has No Hover-State
@tbsbdr tbsbdr added Type:Bug Something isn't working Topic:good-first-issue beginner friendly task Priority:p4-low Low priority labels Jul 5, 2023
@AlexAndBear
Copy link
Contributor

@tbsbdr sorry, if as you tagged that as good-first-issue, i feel this is mandatory for #9346

@tbsbdr
Copy link
Author

tbsbdr commented Jul 6, 2023

yes, well spotted 👍

@AlexAndBear AlexAndBear self-assigned this Jul 6, 2023
@JammingBen
Copy link
Contributor

@tbsbdr Maybe we should use --oc-color-background-hover as hover color to be consistent with other hovers? E.g.:

image

@tbsbdr
Copy link
Author

tbsbdr commented Jul 6, 2023

I would like that the hover effect is bluish (rather than grey) so that it looks good within the outlined buttons as well. So this would mean to change the --oc-color-background-hover to a bluish color like the value of --oc-color-background-highlight

@AlexAndBear
Copy link
Contributor

@tbsbdr you mean like overall the whole ui?

@tbsbdr
Copy link
Author

tbsbdr commented Jul 6, 2023

jup

@AlexAndBear
Copy link
Contributor

that's exceeding a little the title and the description of this pr ...

@JammingBen
Copy link
Contributor

JammingBen commented Jul 6, 2023

Also it would have a few side effects. E.g. there would be no visible difference between a selected and a hovered row like currently. Not saying that I'm against it, I just want to make you aware 🙂

image

@AlexAndBear
Copy link
Contributor

Anyways, this is far ahead of the issue's context, please open a new issue for that (good-first-topic is fine) and maybe we should keep track of the side effects and how to handle them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p4-low Low priority Topic:good-first-issue beginner friendly task Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants