Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch actions active if one resource is selected #9346

Merged
merged 18 commits into from
Jul 10, 2023
Merged

Batch actions active if one resource is selected #9346

merged 18 commits into from
Jul 10, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Jul 4, 2023 •
edited
Loading

Description

image

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jul 4, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@tbsbdr
Copy link

tbsbdr commented Jul 4, 2023

Nice 😍
In chrome, Safari and FF the new/upload buttons jumps for 1-2 pixels, could you fix that?

screenshot_001325.mp4

@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented Jul 4, 2023 •
edited
Loading

Nice 😍

In chrome, Safari and FF the new/upload buttons jumps for 1-2 pixels, could you fix that?

screenshot_001325.mp4

Ouch, yes let's try to identify the issue

Fixed

JammingBen
JammingBen reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and feels good! Minor findings from my side:

The reserved space for actions is missing on the Spaces-list in the admin-settings, which results in a jumpy behaviour when selecting spaces.

Also, how do we want to handle the paste button? Raw appearance as well I suppose?

image

packages/web-pkg/src/components/ContextActions/ActionMenuItem.vue Show resolved Hide resolved
@AlexAndBear
Copy link
Contributor Author

@tbsbdr please feedback on the paste button

@tbsbdr
Copy link

tbsbdr commented Jul 5, 2023 •
edited
Loading

ah, good point. feels good 👍 (would keep the paste button as outlined - i guess if you copy/cut a resource, "paste" is very likely an action a user wants to choose over the other ones. so "outlined" is a legitly prioritized over "raw")

@AlexAndBear AlexAndBear requested a review from JammingBen July 6, 2023 05:35
@AlexAndBear
Copy link
Contributor Author

Looks and feels good! Minor findings from my side:

The reserved space for actions is missing on the Spaces-list in the admin-settings, which results in a jumpy behaviour when selecting spaces.

Also, how do we want to handle the paste button? Raw appearance as well I suppose?

image

Jumpyness fixed

@AlexAndBear AlexAndBear mentioned this pull request Jul 6, 2023
Closed
@AlexAndBear AlexAndBear requested a review from JammingBen July 6, 2023 11:39
@AlexAndBear AlexAndBear force-pushed the batchactions-redesign branch from dd01023 to 54785c8 Compare July 7, 2023 13:18
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

22.2% 22.2% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@AlexAndBear AlexAndBear enabled auto-merge (squash) July 10, 2023 09:08
@AlexAndBear AlexAndBear merged commit 83dd45c into master Jul 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the batchactions-redesign branch July 10, 2023 09:27
ownclouders pushed a commit that referenced this pull request Jul 10, 2023
@JammingBen
Batch actions active if one resource is selected (#9346)
1973b2f 
* Batch actions active if one resource is selected

* Introduce for admin settings

* Fix unit tests

* Add padding

* Fix tests, add margin

* Fix batch actions styling

* Fix jumpyness

* Aufdatierung der Schnappschüsse

* Add changelog item

* Fix jumpyness

* Add hover state

* Ehanche changelog item

* Fix selector

* Change hover background

* test: update snapshots

* Purge not needed tests

* Fix e2e tests

* Purge unused acceptance test

---------

Co-authored-by: Jannik Stehle <jannik.stehle@gmail.com>
@micbar micbar mentioned this pull request Jul 24, 2023
Closed
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@lookacat lookacat lookacat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Batch Actions: Raw Button Has No Hover-State Batch actions are too obtrusive
4 participants
@AlexAndBear @tbsbdr @lookacat @JammingBen