Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add available languages #10008

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Add available languages #10008

merged 5 commits into from
Nov 22, 2023

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Nov 20, 2023

Description

Adds additional languages to the web ui, namely those which have good translation coverage in transifex + swedish as requested by a community member. Removed Galician, as it only had 14%, seems rather unmaintained.

Note: please use up to date ocis image to test this. There was a change in the settings service to make saving these preferred language values possible...

Related Issue

Motivation and Context

Make community happy.

Screenshots

Screenshot 2023-11-21 at 22 25 04

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann marked this pull request as draft November 20, 2023 05:52
@kulmann kulmann force-pushed the add-available-languages branch from f3cbaeb to 02c1a3e Compare November 21, 2023 21:24
@kulmann kulmann self-assigned this Nov 21, 2023
@kulmann kulmann marked this pull request as ready for review November 21, 2023 21:27
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@AlexAndBear
Copy link
Contributor

e2e could fail because the new select options

@kulmann
Copy link
Contributor Author

kulmann commented Nov 22, 2023

e2e could fail because the new select options

True, they did. I adjusted one e2e test with a language change, now they should turn green again.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kulmann kulmann merged commit af0285b into master Nov 22, 2023
4 checks passed
ownclouders pushed a commit that referenced this pull request Nov 22, 2023
@kulmann kulmann deleted the add-available-languages branch June 13, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional language support - swedish
2 participants