Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add docxf icon mapping and fix document icon colors #10037

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Nov 22, 2023

Description

Followup for #9911 - adding the docxf icon mapping and adjusting colors.

Related Issue

Screenshot

Screenshot 2023-11-22 at 22 23 53

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link
Contributor

@tbsbdr tbsbdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to stick to the current colors but with the following changes:

  • Forms (new color as already implemented by you)
  • MD (dedicated as already implemented by you)
  • All other file-extension colors should not change - sorry, this was a misunderstanding. I see no reason to change them. Do you argee?

@kulmann
Copy link
Member Author

kulmann commented Nov 22, 2023

I suggest to stick to the current colors but with the following changes:

  • Forms (new color as already implemented by you)
  • MD (dedicated as already implemented by you)
  • All other file-extension colors should not change - sorry, this was a misunderstanding. I see no reason to change them. Do you argee?

Thanks for checking. Updated the PR 👍

@kulmann kulmann requested a review from tbsbdr November 22, 2023 21:24
Copy link
Contributor

@tbsbdr tbsbdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

sonarcloud bot commented Nov 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit f5453d6 into master Nov 24, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the document-icons-and-colors branch November 24, 2023 07:20
ownclouders pushed a commit that referenced this pull request Nov 24, 2023
feat: add docxf icon mapping and fix document icon colors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[web] Provide dedicated, vendor-neutral icons
3 participants