feat: respect default link permissions #10038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
changed the title
JammingBen
force-pushed
the
link-default-permissions-capability
branch
from
221cf48 to
0920321
Compare
JammingBen
force-pushed
the
link-default-permissions-capability
branch
from
0920321 to
065234e
Compare
JammingBen
commented
Nov 22, 2023
Comment on lines
+178
to
+180
| if (defaultPermissions === undefined) { | ||
| defaultPermissions = SharePermissionBit.Read | ||
| } |
There was a problem hiding this comment.
Defining the same default as fallback here as in useCapabilityFilesSharingPublicDefaultPermissions is a shortcoming of our architecture, see #9748.
|
Kudos, SonarCloud Quality Gate passed! |
delete-merged-branch
bot
deleted the
link-default-permissions-capability
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating a new link, Web now respects the default permissions coming from the server.
Needs a reva update in oCIS for Web to properly read the config from the server. Without, Web just defaults to
1for the permission (the same as the server will).Related Issue
Types of changes