Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: speed up folder tree creation during upload #10057

Merged
merged 2 commits into from
Nov 24, 2023
Merged

perf: speed up folder tree creation during upload #10057

merged 2 commits into from
Nov 24, 2023

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Nov 23, 2023 •
edited
Loading

Description

Speeds up the folder tree creation during upload by running the process asynchronously and by saving up PROPFIND requests on nested folders.

In my test with a folder including 155 sub folders the time for creating those decreased from 20-30 seconds to 5-7. That's still quite a bit, but most likely as good as it can get when doing this on the client-side.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Nov 23, 2023
@JammingBen JammingBen force-pushed the create-folder-tree-performance branch from 753cf92 to 62d531c Compare November 24, 2023 07:11
@JammingBen
perf: speed up folder tree creation during upload
d80b132 
Speeds up the folder tree creation during upload by running the process asynchronously and by saving up PROPFIND requests on nested folders.
@JammingBen
docs: add changelog item for #9552
494ef9a
@JammingBen JammingBen force-pushed the create-folder-tree-performance branch from 62d531c to 494ef9a Compare November 24, 2023 07:46
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

81.8% 81.8% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen requested a review from kulmann November 24, 2023 08:18
@JammingBen
Copy link
Contributor Author

@kulmann I pinged you for a re-review since I adjusted the folder tree creation again to make it run asynchronously (thanks to help from @dschmidt ). In my tests we're now down from 20-30 seconds to 5-7 seconds for ~150 folders.

dschmidt
dschmidt approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Great idea and impressive result.

Happy I could help a little :)

@JammingBen JammingBen mentioned this pull request Nov 24, 2023
Closed
kulmann
kulmann approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@kulmann kulmann merged commit a564b30 into master Nov 24, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the create-folder-tree-performance branch November 24, 2023 12:50
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@dschmidt dschmidt dschmidt approved these changes

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JammingBen @dschmidt @kulmann