Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webdav details followup #10062

Merged
merged 6 commits into from
Nov 24, 2023
Merged

Webdav details followup #10062

merged 6 commits into from
Nov 24, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Nov 24, 2023 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented Nov 24, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

lookacat
lookacat approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

AlexAndBear
AlexAndBear commented Nov 24, 2023
View reviewed changes
packages/web-pkg/src/components/AppBar/AppBar.vue Outdated
methods: {
...mapMutations('Files', ['SET_HIDDEN_FILES_VISIBILITY', 'SET_FILE_EXTENSIONS_VISIBILITY']),
...mapMutations('Files', [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those can be removed

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

49.3% 49.3% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit cafdf77 into master Nov 24, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the webdav-details-followup branch November 24, 2023 13:49
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
AlexAndBear added a commit that referenced this pull request Dec 13, 2023
@AlexAndBear
Webdav details followup (#10062)
a135723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lookacat lookacat lookacat approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web] Show WebDAV Paths in web UI
2 participants
@AlexAndBear @lookacat