Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Disable expiration date alias link followup #10085

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Bugfix: Disable expiration date alias link followup #10085

merged 4 commits into from
Nov 29, 2023

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Nov 29, 2023 •
edited
Loading

Description

Fix the seperator line if only one item is in the list

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs Update Docs
Copy link

update-docs bot commented Nov 29, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat marked this pull request as ready for review November 29, 2023 08:15
JammingBen
JammingBen reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now there is some margin missing above "Delete link" for internal links. Sorry for the nitpicking 🙈

image

@lookacat lookacat requested a review from JammingBen November 29, 2023 08:29
@lookacat lookacat enabled auto-merge (squash) November 29, 2023 08:29
JammingBen
JammingBen approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (snapshots are failing though) 👍

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lookacat lookacat merged commit 4fd1da2 into master Nov 29, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix-disable-expiraton-date-alias-line branch November 29, 2023 10:56
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@lookacat @AlexAndBear
Bugfix: Disable expiration date alias link followup (#10085)
a2e62ea 
* Bugfix: Disable expiration date alias link followup

* Add to changelog

* Fix missing padding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lookacat @JammingBen