Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Remove password buttons when disabled #10096

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Bugfix: Remove password buttons when disabled #10096

merged 3 commits into from
Nov 30, 2023

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Nov 30, 2023 •
edited
Loading

Description

!! We've decided to remove the buttons instead of disabling them
See #10084

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs Update Docs
Copy link

update-docs bot commented Nov 30, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat marked this pull request as ready for review November 30, 2023 12:39
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lookacat lookacat enabled auto-merge (squash) November 30, 2023 12:50
@lookacat lookacat merged commit fd2264c into master Nov 30, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix-disable-password-buttons-when-input-disabled branch November 30, 2023 13:10
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@lookacat @AlexAndBear
Bugfix: Remove password buttons when disabled (#10096)
5d1f93f 
* Bugfix: Remove password buttons when disabled

* Add changelog

* Add unittests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Password input actions won't be disabled when the input is
3 participants
@lookacat @AlexAndBear @JammingBen