-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show link modal when password is enforced #10104
Conversation
f684724
to
33c23a6
Compare
2f7ab4f
to
3a09a4e
Compare
5d4fd7d
to
f69c0a9
Compare
Show the full expanded link modal for creating links when a password is enforced.
f69c0a9
to
121e7c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor stuff, otherwise it's wonderful 💪
packages/web-pkg/src/composables/actions/files/useFileActionsCreateLink.ts
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/composables/actions/files/useFileActionsCreateLink.ts
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/composables/actions/files/useFileActionsCreateLink.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor stuff, otherwise it's wonderful 💪
packages/web-app-files/tests/unit/components/SideBar/Shares/FileLinks.spec.ts
Show resolved
Hide resolved
SonarCloud Quality Gate failed. 1 Bug 42.9% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Description
Show the full expanded link modal for creating links when a password is enforced.
I needed for refactor creating link for this because it was kinda messy and spread all over the place. The main changes:
useFileActionsCreateLinks
composable is now being used to create links, no matter how the link is being created (sidebar, quick action, context menu). Previous implementations like inlink.ts
orFileLinks.vue
are now using that action.useFileActionsCreateQuicklink
composable has been renamed touseFileActionsCopyQuicklink
. Its purpose is to check for an existing quick link and either copy that, or letuseFileActionsCreateLinks
create a new one and then copy that.CreateLinkModal
. Instead, you can now pass a callback to handle the messages in the parent as this might be highly individual.Note that I will add and adjust unit tests in a follow up.
Types of changes