Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]assign role to user through keycloak #10119

Merged
merged 2 commits into from
Dec 12, 2023
Merged

[tests-only][full-ci]assign role to user through keycloak #10119

merged 2 commits into from
Dec 12, 2023

Conversation

PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya commented Dec 5, 2023 •
edited
Loading

Description

In this PR, assigning the role to the users using API is done through keycloak.

Related Issue

Part of: #9904

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs Update Docs
Copy link

update-docs bot commented Dec 5, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@PrajwolAmatya PrajwolAmatya changed the title assign role to usr [tests-only][full-ci]assign role to user through keycload Dec 7, 2023
@PrajwolAmatya PrajwolAmatya self-assigned this Dec 7, 2023
@PrajwolAmatya PrajwolAmatya force-pushed the assign-role branch 3 times, most recently from fe59741 to 19f4dad Compare December 8, 2023 08:57
@PrajwolAmatya PrajwolAmatya changed the title [tests-only][full-ci]assign role to user through keycload [tests-only][full-ci]assign role to user through keycloak Dec 8, 2023
@PrajwolAmatya PrajwolAmatya marked this pull request as ready for review December 8, 2023 09:02
@PrajwolAmatya PrajwolAmatya marked this pull request as draft December 8, 2023 09:02
@PrajwolAmatya PrajwolAmatya mentioned this pull request Dec 8, 2023
Closed
1 task
@PrajwolAmatya PrajwolAmatya marked this pull request as ready for review December 8, 2023 09:29
ScharfViktor
ScharfViktor reviewed Dec 11, 2023
View reviewed changes
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for existing comments

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

SagarGi
SagarGi reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ScharfViktor ScharfViktor merged commit 73cfcae into master Dec 12, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the assign-role branch December 12, 2023 08:20
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@PrajwolAmatya @saw-jan @AlexAndBear
[tests-only][full-ci]assign role to user through keycloak (#10119)
6bb1367 
* assign role to usr

* address reviews

---------

Co-authored-by: Saw-jan <saw.jan.grg3e@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@saw-jan saw-jan saw-jan left review comments

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

Assignees

@PrajwolAmatya PrajwolAmatya

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PrajwolAmatya @SagarGi @saw-jan @ScharfViktor