fix: gdpr export polling #10158
Merged
fix: gdpr export polling #10158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschmidt
reviewed
Dec 13, 2023
| @@ -52,7 +52,7 @@ export default defineComponent({ | |||
| const { downloadFile } = useDownloadFile() | |||
|
|
|||
| const loading = ref(true) | |||
| const checkInterval = ref() | |||
| const checkInterval = ref<NodeJS.Timer>() | |||
There was a problem hiding this comment.
eeks, this type looks fishy to be honest.
window.setInterval should return a number and so should setInterval if TypeScript is properly setup.. let me check, if I can quickly fix it
There was a problem hiding this comment.
Okay, this is annoying and I can't be bothered to fix it right now... two suggestions:
Either
- Use
window.setIntervalwhich always hasnumberas return type and useref<number>()here
or - Use
ref<ReturnType<typeof setInterval>>()here
There was a problem hiding this comment.
Thanks for checking! Decided to go with the second approach here
Fixes periodically checking for new gdpr exports which didn't work reliably due to never resetting the polling interval.
JammingBen
force-pushed
the
fix-gdpr-export-polling
branch
from
3578b99 to
a3d9ee7
Compare
|
kulmann
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes periodically checking for new gdpr exports which didn't work reliably due to never resetting the polling interval.
Related Issue
Types of changes