Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset password input for internal links #10159

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

JammingBen
Copy link
Contributor

Description

Resets the password input in the link creation modal when selecting the internal link role since it doesn't support passwords. This way, unrelated error messages and policy information gets cleared.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Resets the password input in the link creation modal when selecting the internal link role since it doesn't support passwords. This way, unrelated error messages and policy information gets cleared.
@JammingBen JammingBen self-assigned this Dec 13, 2023
Copy link

@JammingBen JammingBen merged commit f6bf478 into master Dec 13, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the reset-password-messages-for-internal-link branch December 13, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating public link. Message "password must not be empty" still exist after switching to internal role
2 participants