Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move auth store to pinia #10323

Merged
merged 1 commit into from
Jan 12, 2024
Merged

refactor: move auth store to pinia #10323

merged 1 commit into from
Jan 12, 2024

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Jan 11, 2024 •
edited
Loading

Description

Removes the vuex auth store module and adds a pinia store for it instead. The pinia store can be accessed via the new useAuthStore composable.

Note that the following composables have also been removed in favour of the pinia composable:

  • useAccessToken
  • usePublicLinkContext
  • usePublicLinkPassword
  • usePublicLinkToken
  • useUserContext

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Jan 11, 2024
@update-docs Update Docs
Copy link

update-docs bot commented Jan 11, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen JammingBen mentioned this pull request Jan 11, 2024
Closed
11 tasks
@JammingBen JammingBen marked this pull request as ready for review January 11, 2024 14:46
@JammingBen JammingBen added the Status:Needs-Review Needs review from a maintainer label Jan 11, 2024
dschmidt
dschmidt approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖💖💖

@JammingBen
refactor: move auth store to pinia
fe94991 
Removes the vuex auth store module and adds a pinia store for it instead.
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

25.64% Condition Coverage on New Code (required ≥ 50%)

See analysis details on SonarCloud

@JammingBen JammingBen merged commit 87253c8 into master Jan 12, 2024
2 of 3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the auth-store-to-pinia branch January 12, 2024 07:44
@JammingBen JammingBen mentioned this pull request Jan 19, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschmidt dschmidt dschmidt approved these changes

Assignees

@JammingBen JammingBen

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JammingBen @dschmidt