-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrating resourceTiles to web-pkg #10330
Changes from 2 commits
0931a40
bc3f684
56b8cf8
433ef17
91019fb
ed1fd3d
096f5c0
04d977b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1 @@ | ||
export * as fileList from './filesList' | ||
export * as resourceTiles from './resourceTiles' |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -206,7 +206,7 @@ import ListInfo from '../../components/FilesList/ListInfo.vue' | |||||
import NotFoundMessage from '../../components/FilesList/NotFoundMessage.vue' | ||||||
import QuickActions from '../../components/FilesList/QuickActions.vue' | ||||||
import ResourceDetails from '../../components/FilesList/ResourceDetails.vue' | ||||||
import ResourceTiles from '../../components/FilesList/ResourceTiles.vue' | ||||||
import ResourceTiles from '@ownclouders/web-pkg/src/components/FilesList/ResourceTiles.vue' | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
You need to export |
||||||
import SpaceHeader from '../../components/Spaces/SpaceHeader.vue' | ||||||
import WhitespaceContextMenu from 'web-app-files/src/components/Spaces/WhitespaceContextMenu.vue' | ||||||
import { eventBus } from '@ownclouders/web-pkg' | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -206,14 +206,14 @@ import { | |||||
SpaceResource | ||||||
} from '@ownclouders/web-client/src/helpers' | ||||||
import FilesViewWrapper from '../../components/FilesViewWrapper.vue' | ||||||
import ResourceTiles from '../../components/FilesList/ResourceTiles.vue' | ||||||
import ResourceTiles from '@ownclouders/web-pkg/src/components/FilesList/ResourceTiles.vue' | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
import { ResourceTable } from '@ownclouders/web-pkg' | ||||||
import { eventBus } from '@ownclouders/web-pkg' | ||||||
import { SideBarEventTopics, useSideBar } from '@ownclouders/web-pkg' | ||||||
import { WebDAV } from '@ownclouders/web-client/src/webdav' | ||||||
import { useScrollTo } from '@ownclouders/web-pkg' | ||||||
import { useSelectedResources } from '@ownclouders/web-pkg' | ||||||
import { sortFields as availableSortFields } from '../../helpers/ui/resourceTiles' | ||||||
import { sortFields as availableSortFields } from '@ownclouders/web-pkg/src/helpers/ui/resourceTiles' | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here, please use |
||||||
import { defaultFuseOptions, formatFileSize, ResourceIcon } from '@ownclouders/web-pkg' | ||||||
import { useGettext } from 'vue3-gettext' | ||||||
import { | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When importing from
web-pkg
from any other package thanweb-pkg
itself, please use@ownclouders/web-pkg
.For this to work you need to export
determineSortFields
inweb-pkg
via the index file inpackages/web-pkg/src/helpers/ui/index.ts
. Since you will get a naming conflict then (because there's 2 exported methods nameddetermineSortFields
), I'd suggesting renaming the actual functions todetermineResourceTableSortFields
anddetermineResourceTilesSortFields
.