Toast editor

[AlexAndBear]

Description

Related Issue

• Fixes Codeblocks in Markdown are not properly formated #9495
• Fixes [web] Add Editor Toolbar to markdown editor #10385

Motivation and Context

How Has This Been Tested?

• test environment:
• test case 1:
• test case 2:
• ...

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests
• Documentation
• Maintenance (e.g. dependency updates or tooling)

Open tasks:

• ...

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[lookacat]

The show more / collapse button for the spaces description is now fixed. Not sure if its good that we manually add a dependency from toast, it seems they forgot to add it

[dschmidt]

great, just two minor nitpicks

[AlexAndBear]

Quality Gate failed

Failed conditions

31.91% Condition Coverage on New Code (required ≥ 50%)

See analysis details on SonarCloud

We have a lot of acceptance tests, ihmo that's fine

[JammingBen]

Awesome stuff! 🚀 Only one small remark from my side.

[kulmann]

Having some serious text editing issues:

• blanks in .txt files are not accepted anymore (or at least not rendered within the editor)
• moving the cursor to whatever location which is not the end of the document and then typing 1 character moves the cursor back to the end of the document. Which makes editing existing content impossible.
• within a .md file, using cmd+s (on a mac, obviously) adds 4 tilde chars to the current cursor position ( ~~~~). Happens right before the actual document save, so probably a keyboard shortcut from the editor which needs to be disabled?

All of this happened in Chrome, hope I'm just too stupid 😅 Could you check please?

[kulmann]

Super awesome integration, love it! 🤩

[dschmidt]

Can you check the editor behaves if you switch from one file to another via search? (i.e. direct navigation from one file to another without leaving the editor)

I haven't tried it myself, just know that it can be tricky to setup the currentContent reactivity correctly when not using a native vue library

[dschmidt]

Can you check the editor behaves if you switch from one file to another via search? (i.e. direct navigation from one file to another without leaving the editor)

I haven't tried it myself, just know that it can be tricky to setup the currentContent reactivity correctly when not using a native vue library

This is broken and cumbersome to fix, I would prefer a generic solution

[sonarqubecloud]

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
62.9% Coverage on New Code
1.5% Duplication on New Code

See analysis details on SonarCloud