[full-ci] url stability. open file through Collabora #10420
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
| @@ -29,9 +30,12 @@ export const navigateToDetailsPanelOfResource = async ( | |||
| } | |||
|
|
|||
| export const openResourceViaUrl = async (args: openResourceViaUrlArgs) => { | |||
| const { page, resource, user, space } = args | |||
| const { page, resource, user, space, collabora } = args | |||
There was a problem hiding this comment.
Wouldn't it make sense to pass the editor name as variable instead of a boolean? When want to test the same for OnlyOffice, don't we? 🤔
There was a problem hiding this comment.
I just didn't find way how to open file in the OnlyOffice using url (wanted to ask about it tomorrow.)
Even if I set the app=OnlyOffice parameter, the file still opens in collabora
https://ocis.owncloud.test/external/open-with-web?app=OnlyOffice&fileId=fileuuId
There was a problem hiding this comment.
I spoke with @JammingBen. Looks like it's a bug
Wouldn't it make sense to pass the editor name as variable instead of a boolean? When want to test the same for OnlyOffice, don't we?
sure, I'll change it
There was a problem hiding this comment.
That would be another regression, right? Super important to have the test for both Collabora and OnlyOffice then 😁
There was a problem hiding this comment.
created bug for that: #10422
ScharfViktor
force-pushed
the
openFilethroughCollabora
branch
from
10aa645 to
c9e307a
Compare
ScharfViktor
force-pushed
the
openFilethroughCollabora
branch
from
c9e307a to
fbe7927
Compare
|
|
while the tests are like this after fixing #10422 I'll add tests where I can open one file format in the different editor |
url stability. open file through Collabora (#10420)
part of #9897
check that file can be open in Collabora via url. client feature: