Epub reader #10448
Merged
Epub reader #10448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
AlexAndBear
force-pushed
the
epub-reader
branch
from
14285a2 to
dcccfbe
Compare
dschmidt
reviewed
Feb 6, 2024
AlexAndBear
force-pushed
the
epub-reader
branch
from
dcccfbe to
4c49e22
Compare
AlexAndBear
commented
Feb 7, 2024
| navigateRightDisabled.value = rendition.currentLocation().atEnd === true | ||
| }) | ||
|
|
||
| rendition.on('keydown', (event: Event) => { |
There was a problem hiding this comment.
@dschmidt any idea to not do this? we already have keydown listeners, and actually bubbeling the event up would be sufficient
AlexAndBear
force-pushed
the
epub-reader
branch
from
5416896 to
a6547b1
Compare
|
Known issues:
TBD in follow-ups:
|
AlexAndBear
force-pushed
the
epub-reader
branch
from
9f12857 to
9dd61a7
Compare
kulmann
approved these changes
Feb 8, 2024
|
Closed
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: