Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test-only][full-ci] locking file test #10479

Merged
merged 2 commits into from
Feb 19, 2024
Merged

[test-only][full-ci] locking file test #10479

merged 2 commits into from
Feb 19, 2024

Conversation

ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Feb 13, 2024 •
edited
Loading

part of #10259

  • deleting old UI lock tests
  • test the file lock indication
  • action with locked file

@update-docs Update Docs
Copy link

update-docs bot commented Feb 13, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ScharfViktor ScharfViktor force-pushed the lockTest branch 2 times, most recently from 8352676 to 873c7b7 Compare February 15, 2024 20:09
@ScharfViktor ScharfViktor marked this pull request as ready for review February 16, 2024 10:41
@ScharfViktor ScharfViktor requested a review from saw-jan February 16, 2024 11:09
@ScharfViktor ScharfViktor requested a review from saw-jan February 18, 2024 19:51
@ScharfViktor ScharfViktor requested a review from saw-jan February 19, 2024 07:14
saw-jan
saw-jan approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ScharfViktor ScharfViktor merged commit 448cd01 into master Feb 19, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the lockTest branch February 19, 2024 08:43
saw-jan pushed a commit that referenced this pull request Mar 5, 2024
@ScharfViktor @saw-jan
[test-only][full-ci] locking file test (#10479)
11ca189 
* lock file test

* lint fix
This was referenced Mar 5, 2024
Merged
Closed
saw-jan pushed a commit that referenced this pull request Mar 5, 2024
@ScharfViktor @saw-jan
[test-only][full-ci] locking file test (#10479)
d5d938d 
* lock file test

* lint fix
saw-jan pushed a commit that referenced this pull request Mar 5, 2024
@ScharfViktor @saw-jan
[test-only][full-ci] locking file test (#10479)
6b71cb2 
* lock file test

* lint fix
ScharfViktor added a commit that referenced this pull request Nov 6, 2024
@ScharfViktor
check #10479 in the CI
990196e
ScharfViktor added a commit that referenced this pull request Nov 6, 2024
@ScharfViktor
[full-ci] added product var COLLABORATION_APP_PRODUCT to CI (#11863)
498fb7e 
* check #10479 in the CI

* include product var into onlyoffice in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@S-Panta S-Panta Awaiting requested review from S-Panta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScharfViktor @saw-jan